Skip to content

CI: Miri flag passing needs to be fixed #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Apr 23, 2021 · 1 comment
Closed

CI: Miri flag passing needs to be fixed #48

RalfJung opened this issue Apr 23, 2021 · 1 comment

Comments

@RalfJung
Copy link

With rust-lang/miri#1769 having landed, this way of passing Miri flags will soon stop working:

crunch-lang/.github/workflows/main.yml

Line 255 in e51945a

cargo +nightly miri test -- -Zmiri-disable-isolation

This should now instead be

MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test
@Kixiron
Copy link
Owner

Kixiron commented Jun 1, 2021

Fixed in b4ef3fc, thanks!

@Kixiron Kixiron closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @Kixiron