From 0ac5c37c2bf55395a42b87e3f4ccd3e735733357 Mon Sep 17 00:00:00 2001 From: Jess Frazelle Date: Mon, 27 Jan 2025 11:03:38 -0800 Subject: [PATCH 1/3] clearer docs (#743) Signed-off-by: Jess Frazelle --- modeling-cmds/src/def_enum.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modeling-cmds/src/def_enum.rs b/modeling-cmds/src/def_enum.rs index 9da7e7ff..ccab68ec 100644 --- a/modeling-cmds/src/def_enum.rs +++ b/modeling-cmds/src/def_enum.rs @@ -1221,6 +1221,8 @@ define_modeling_cmd_enum! { /// Set the units of the scene. /// For all following commands, the units will be interpreted as the given units. + /// Any previously executed commands will not be affected or have their units changed. + /// They will remain in the units they were originally executed in. #[derive(Debug, Clone, PartialEq, Serialize, Deserialize, JsonSchema, ModelingCmdVariant)] #[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))] #[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))] From a18cb7f56c3624d6e79e5b2a171c4474900e5cad Mon Sep 17 00:00:00 2001 From: Jess Frazelle Date: Mon, 27 Jan 2025 11:27:23 -0800 Subject: [PATCH 2/3] ensure we dont serialize if none (#744) Signed-off-by: Jess Frazelle --- modeling-cmds/src/def_enum.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modeling-cmds/src/def_enum.rs b/modeling-cmds/src/def_enum.rs index ccab68ec..e8fa603c 100644 --- a/modeling-cmds/src/def_enum.rs +++ b/modeling-cmds/src/def_enum.rs @@ -790,7 +790,7 @@ define_modeling_cmd_enum! { pub cut_type: CutType, /// The ID to use for the newly created fillet face. /// If not provided, the server will randomly generate one. - #[serde(default)] + #[serde(default, skip_serializing_if = "Option::is_none")] pub face_id: Option, } From 69e8ed7a083e752d35dded7a9548cafd19b1f7b8 Mon Sep 17 00:00:00 2001 From: Jess Frazelle Date: Mon, 27 Jan 2025 11:41:45 -0800 Subject: [PATCH 3/3] Release modeling-cmds 0.2.93 (#745) --- Cargo.lock | 2 +- modeling-cmds/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index c1ae3f0f..7254c68f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1957,7 +1957,7 @@ dependencies = [ [[package]] name = "kittycad-modeling-cmds" -version = "0.2.92" +version = "0.2.93" dependencies = [ "anyhow", "bson", diff --git a/modeling-cmds/Cargo.toml b/modeling-cmds/Cargo.toml index 019b7550..9d8811a4 100644 --- a/modeling-cmds/Cargo.toml +++ b/modeling-cmds/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "kittycad-modeling-cmds" -version = "0.2.92" +version = "0.2.93" edition = "2021" authors = ["KittyCAD, Inc."] description = "Commands in the KittyCAD Modeling API"