From 6014cc88c045efd822c03a02e7cd986cc0fe01e2 Mon Sep 17 00:00:00 2001
From: Kenneth Russell <kbrussel@alum.mit.edu>
Date: Tue, 17 May 2022 16:47:58 -0700
Subject: [PATCH] Add test of comma operator in constant-expression context.
In GLSL 3.00 section 12.43 "Sequence operator and constant
expressions" this is disallowed.
Associated with http://crbug.com/1324747 .
---
sdk/tests/conformance2/glsl3/00_test_list.txt | 1 +
...omma-operator-not-constant-expression.html | 63 +++++++++++++++++++
2 files changed, 64 insertions(+)
create mode 100644 sdk/tests/conformance2/glsl3/comma-operator-not-constant-expression.html
diff --git a/sdk/tests/conformance2/glsl3/00_test_list.txt b/sdk/tests/conformance2/glsl3/00_test_list.txt
index 5a47d470f9..daed1b24ee 100644
--- a/sdk/tests/conformance2/glsl3/00_test_list.txt
+++ b/sdk/tests/conformance2/glsl3/00_test_list.txt
@@ -9,6 +9,7 @@ array-in-complex-expression.html
--min-version 2.0.1 array-length-side-effects.html
attrib-location-length-limits.html
bool-type-cast-bug-uint-ivec-uvec.html
+--min-version 2.0.1 comma-operator-not-constant-expression.html
compare-structs-containing-arrays.html
compound-assignment-type-combination.html
const-array-init.html
diff --git a/sdk/tests/conformance2/glsl3/comma-operator-not-constant-expression.html b/sdk/tests/conformance2/glsl3/comma-operator-not-constant-expression.html
new file mode 100644
index 0000000000..4a76ac5963
--- /dev/null
+++ b/sdk/tests/conformance2/glsl3/comma-operator-not-constant-expression.html
@@ -0,0 +1,63 @@
+<!--
+Copyright (c) 2022 The Khronos Group Inc.
+Use of this source code is governed by an MIT-style license that can be
+found in the LICENSE.txt file.
+-->
+
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<title>Comma operator should be disallowed in constant-expression context</title>
+<link rel="stylesheet" href="../../resources/js-test-style.css"/>
+<link rel="stylesheet" href="../../resources/glsl-feature-tests.css"/>
+<script src="../../js/js-test-pre.js"></script>
+<script src="../../js/webgl-test-utils.js"></script>
+<script src="../../js/glsl-conformance-test.js"></script>
+</head>
+<body>
+<div id="description"></div>
+<div id="console"></div>
+<script id="vshader" type="x-shader/x-vertex">#version 300 es
+in vec3 position;
+
+void main() {
+ gl_Position = vec4(position, 1.0);
+}
+</script>
+<script id="fshader" type="x-shader/x-fragment">#version 300 es
+precision highp float;
+
+uniform float time;
+uniform vec2 resolution;
+out vec4 out_color;
+
+void main() {
+ int array[(2, 3)]; // <-- no error
+
+ vec2 position = -1.0 + 2.0 * gl_FragCoord.xy / resolution.xy;
+ float red = abs(sin(position.x * position.y + time / 5.0));
+ float green = abs(sin(position.x * position.y + time / 4.0));
+ float blue = abs(sin(position.x * position.y + time / 3.0));
+ out_color = vec4(red, green, blue, 1.0);
+}
+</script>
+<script type="application/javascript">
+"use strict";
+description();
+const wtu = WebGLTestUtils;
+const tests = [
+ {
+ vShaderSource: wtu.getScript('vshader'),
+ fShaderSource: wtu.getScript('fshader'),
+ vShaderSuccess: true,
+ fShaderSuccess: false,
+ linkSuccess: false,
+ passMsg: 'Comma operator should be disallowed in constant-expression context, and fail to compile and link'
+ }
+];
+
+GLSLConformanceTester.runTests(tests, 2);
+</script>
+</body>
+</html>