Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify entities vs. visualEntities #2007

Open
igarashitm opened this issue Feb 13, 2025 · 2 comments
Open

Clarify entities vs. visualEntities #2007

igarashitm opened this issue Feb 13, 2025 · 2 comments
Labels
bug Something isn't working refactoring

Comments

@igarashitm
Copy link
Contributor

Please describe the task that needs to be done

Currently CamelRouteResource.getEntities() returns everything other than CamelRouteVisualEntity, which contains other visual entities such as RouteConfiguration

https://github.com/KaotoIO/kaoto/blob/main/packages/ui/src/models/camel/camel-route-resource.ts#L149

It would be better to clarify what getEntities() should return. Having the fact that we also have getVisualEntities() in mind, it would be either

  • All entities, both visual entities and non visual entities
  • Non visual entities

I find it useful if getEntities() would return all entities rather than just non visual entities. In that way it could represent the order of the entities when visual ones and non visual ones are combined.

@lordrip
Copy link
Member

lordrip commented Mar 4, 2025

Clarify:

  • getEntities(): These are non-visible entities, like beans or at some point rest and restConfiguration.
  • getVisualEntities(): Everything that goes rendered in the Canvas

@lordrip
Copy link
Member

lordrip commented Mar 4, 2025

getEntities should only return non-visible entities, whereas getVisualEntities() should return everything going to the Canvas.

@lordrip lordrip added the bug Something isn't working label Mar 4, 2025
@lordrip lordrip moved this from New to Backlog in Kanban Board Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring
Projects
Status: Backlog
Development

No branches or pull requests

2 participants