Skip to content

Commit 22b52ae

Browse files
committed
fix: change sidemenu links without url to text
1 parent 1c78690 commit 22b52ae

File tree

2 files changed

+30
-8
lines changed

2 files changed

+30
-8
lines changed

public/css/kurs-pm-web.scss

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,12 @@ $icon-expanded-svg: 'data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZ
186186
}
187187
}
188188

189+
li.selected {
190+
span.memosLink {
191+
padding: 7px 0;
192+
}
193+
}
194+
189195
#mobileMenu.navbar.navbar-expand-lg.navbar-light {
190196
#mobileMenuContent.navbar-collapse.collapse.show ul.menu.navbar-nav.mr-auto {
191197
& > li.nav-item.node.selected.expanded {
@@ -197,6 +203,9 @@ $icon-expanded-svg: 'data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZ
197203
a.memosLink {
198204
padding-left: 10px;
199205
}
206+
span.memosLink {
207+
padding-left: 10px;
208+
}
200209
}
201210
}
202211

@@ -350,6 +359,11 @@ h2.info {
350359
margin-top: 0;
351360
}
352361

362+
span.nav-link {
363+
padding: 7px 15px 7px 0;
364+
color: #000;
365+
}
366+
353367
.about-container {
354368
ul {
355369
list-style: none;

public/js/app/components/SideMenu.jsx

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const SideMenu = ({ labels, courseCode, language, aboutCourseMemo, courseMemoIte
5252
</a>
5353
</li>
5454
<li className="nav-item node selected expanded">
55-
<a className="nav-link">{labels.courseMemo}</a>
55+
<span className="nav-link">{labels.courseMemo}</span>
5656
<ul className="nav nav-list">
5757
<li className={`nav-item leaf ${aboutCourseMemo ? 'selected' : ''}`}>
5858
<a
@@ -62,13 +62,21 @@ const SideMenu = ({ labels, courseCode, language, aboutCourseMemo, courseMemoIte
6262
{labels.aboutCourseMemos}
6363
</a>
6464
</li>
65-
{courseMemoItems.filter(removedOutdated).map(({ label, url, active }) => (
66-
<li key={label} className={`nav-item leaf ${active ? 'selected' : ''}`}>
67-
<a href={active ? null : url} className="nav-link memosLink" aria-label={label}>
68-
{label}
69-
</a>
70-
</li>
71-
))}
65+
{courseMemoItems.filter(removedOutdated).map(({ label, url, active }) =>
66+
active ? (
67+
<li key={label} className="nav-item leaf selected">
68+
<span className="nav-link memosLink" aria-label={label}>
69+
{label}
70+
</span>
71+
</li>
72+
) : (
73+
<li key={label} className="nav-item leaf">
74+
<a href={active ? null : url} className="nav-link memosLink" aria-label={label}>
75+
{label}
76+
</a>
77+
</li>
78+
)
79+
)}
7280
</ul>
7381
</li>
7482
<li className="nav-item leaf">

0 commit comments

Comments
 (0)