cxx-qt-build: remove CxxQtBuilder::library instead use new and export

Author: ahayzen-kdab

crates/cxx-qt-build/src/interface.rs

@@ -12,7 +12,7 @@ use std::path::{Path, PathBuf};
 use crate::{dir, dir::INCLUDE_VERB, Dependency, Manifest};
 
 /// When generating a library with cxx-qt-build, the library may need to export certain flags or headers.
-/// These are all specified by this Interface struct, which should be passed to the [crate::CxxQtBuilder::library] function.
+/// These are all specified by this Interface struct.
 pub struct Interface {
     // The name of the links keys, whose CXX-Qt dependencies to reexport
     pub(crate) reexport_links: HashSet<String>,

crates/cxx-qt-build/src/lib.rs

@@ -415,18 +415,6 @@ impl CxxQtBuilder {
         }
     }
 
-    /// Create a new builder that is set up to create a library crate that is meant to be
-    /// included by later dependencies.
-    ///
-    /// The headers generated for this crate will be specified
-    pub fn library() -> Self {
-        if link_name().is_none() {
-            panic!("Building a Cxx-Qt based library requires setting a `links` field in the Cargo.toml file.\nConsider adding:\n\tlinks = \"{}\"\nto your Cargo.toml\n", crate_name());
-        }
-
-        Self::new()
-    }
-
     /// Specify rust file paths to parse through the cxx-qt marco
     /// Relative paths are treated as relative to the path of your crate's Cargo.toml file
     pub fn file(mut self, rust_source: impl AsRef<Path>) -> Self {
@@ -480,7 +468,7 @@ impl CxxQtBuilder {
     /// The `Core` module and any modules from dependencies are linked automatically; there is no need to specify them.
     ///
     /// Note that any qt_module you specify here will be enabled for all downstream
-    /// dependencies as well if this crate is built as a library with [CxxQtBuilder::library].
+    /// dependencies as well if this crate is exported.
     /// It is therefore best practice to specify features on your crate that allow downstream users
     /// to disable any qt modules that are optional.
     pub fn qt_module(mut self, module: &str) -> Self {

crates/cxx-qt-lib-extras/build.rs

@@ -6,9 +6,7 @@
 use cxx_qt_build::CxxQtBuilder;
 
 fn main() {
-    let mut builder = CxxQtBuilder::library()
-        .qt_module("Gui")
-        .qt_module("Widgets");
+    let mut builder = CxxQtBuilder::new().qt_module("Gui").qt_module("Widgets");
 
     let rust_bridges = vec![
         "core/qelapsedtimer",

crates/cxx-qt-lib/build.rs

@@ -346,7 +346,7 @@ fn main() {
         cpp_files.extend(["core/qdatetime", "core/qtimezone"]);
     }
 
-    let mut builder = CxxQtBuilder::library()
+    let mut builder = CxxQtBuilder::new()
         // Use a short name due to the Windows file path limit!
         // We don't re-export these headers anyway
         .include_prefix("private")

crates/cxx-qt/build.rs

@@ -6,7 +6,7 @@
 use cxx_qt_build::CxxQtBuilder;
 
 fn main() {
-    let mut builder = CxxQtBuilder::library();
+    let mut builder = CxxQtBuilder::new();
 
     let cpp_files = ["src/connection.cpp"];
     let rust_bridges = ["src/connection.rs", "src/qobject.rs"];

examples/qml_multi_crates/rust/sub1/build.rs

@@ -6,7 +6,7 @@
 use cxx_qt_build::{CxxQtBuilder, QmlModule};
 
 fn main() {
-    CxxQtBuilder::library()
+    CxxQtBuilder::new()
         .qt_module("Network")
         .qml_module(QmlModule::<_, &str> {
             uri: "com.kdab.cxx_qt.demo.sub1",

examples/qml_multi_crates/rust/sub2/build.rs

@@ -6,7 +6,7 @@
 use cxx_qt_build::{CxxQtBuilder, QmlModule};
 
 fn main() {
-    CxxQtBuilder::library()
+    CxxQtBuilder::new()
         .qml_module(QmlModule::<_, &str> {
             uri: "com.kdab.cxx_qt.demo.sub2",
             rust_files: &["src/sub2_object.rs"],