added secondary game ID, along with a bug fix

Author: JustTemmie

README.md

@@ -35,15 +35,16 @@ create a file named `config.json` in the same directory as this file and fill it
     "STEAM_API_KEY": "STEAM_API_KEY",
     "USER_ID": "USER_ID",
 
-    "DISCORD_APPLICATION_ID": "DISCORD_APPLICATION_ID",
+    "DISCORD_APPLICATION_ID": "869994714093465680",
 
     "COVER_ART": {
         "ENABLED": false,
         "STEAM_GRID_API_KEY": "STEAM_GRID_API_KEY"
     },
 
     "NON_STEAM_GAMES": {
-        "ENABLED": false
+        "ENABLED": false,
+        "NON_STEAM_DISCORD_APP_ID": "939292559765803018"
     },
 
     "CUSTOM_GAME_OVERWRITE": {
@@ -73,9 +74,9 @@ the `USER_ID` is the steam user id of the user you want to track.
 
 **NOTE** this is not the same as the display URL of the user.
 
-the easiest way i've found to get the ID is by throwing your profile url into the steamDB calculator https://steamdb.info/calculator/
+the easiest way i've found to get the ID is by throwing your url into the steamDB calculator https://steamdb.info/calculator/
 
-and then taking the ID from that page
+and then taking the ID from that url
 
 ![ExampleImage](readmeimages/steamDB.png)
 
@@ -122,6 +123,10 @@ https://chrome.google.com/webstore/detail/get-cookiestxt/bgaddhkoddajcdgocldbbfl
 
 navigate to your profile on steam, and download the cookie file, naming it "cookies.txt" and save it in the same folder as main.py
 
+the NON_STEAM_DISCORD_APP_ID field is a seprate discord app ID which displays when the game isn't found in discord's cached game list, but is being played as a non steam game. The default app id "939292559765803018" is simply called "a game not on steam"
+
+**NOTE** the NON_STEAM_DISCORD_APP_ID and the DISCORD_APPLICATION_ID from earlier in the config file **CANNOT** be the same, because of how this script is coded, they can have the same name but if you want both to be called the same you must create two applications, with the same name
+
 Note: due to the names of non steam games being set by yourself, steam grid DB might have problems finding icons for the game, but if it's in their database, this script will fetch it
 
 # Custom Game Overwrite
@@ -144,8 +149,8 @@ set an URL to the image you want to use, and a text that will appear when hoveri
 # Python
 python3.8 or higher is required.
 
-run `python3 -m pip install -r requirements.txt` to install all the dependencies
+run `pip install -r requirements.txt` to install all the dependencies
 
 then run `python3 main.py`
 
-(these commands should be platform independent, if they're not PLEASE create an issue and inform me)
+(these are linux commands, if you're on windows you might need to change them into something, idk search it up)

exampleconfig.json

@@ -10,7 +10,8 @@
     },
 
     "NON_STEAM_GAMES": {
-        "ENABLED": false
+        "ENABLED": false,
+        "NON_STEAM_DISCORD_APP_ID": "939292559765803018"        
     },
 
     "CUSTOM_GAME_OVERWRITE": {

main.py

@@ -83,8 +83,10 @@ def web_scrape_steam_presence(USER_URL):
 
     for element in soup.find_all("div", class_="profile_in_game_name"):
         result = element.text.strip()
-    
-        return result
+
+        # the "last online x min ago" field is the same div as the game name
+        if "Last Online" not  in result:
+            return result
 
 # looks into the discord api and steals the app IDs from it
 def get_game_id(gameName):
@@ -275,6 +277,7 @@ def program():
     GRID_KEY = config["COVER_ART"]["STEAM_GRID_API_KEY"]
 
     do_web_scraping = config["NON_STEAM_GAMES"]["ENABLED"]
+    SECONDARY_APP_ID = config["NON_STEAM_GAMES"]["NON_STEAM_DISCORD_APP_ID"]
 
     do_custom_game = config["CUSTOM_GAME_OVERWRITE"]["ENABLED"]
     custom_game_name = config["CUSTOM_GAME_OVERWRITE"]["NAME"]
@@ -366,18 +369,21 @@ def program():
             if GRID_ENABLED:
                 coverImage = get_steam_grid_icon(gameName)
 
-            if app_id == DEFAULT_APP_ID:
+            if app_id == DEFAULT_APP_ID or app_id == SECONDARY_APP_ID:
                 set_game(do_game_title, gameName, coverImage, startTime, do_custom_state, custom_state, do_custom_icon, custom_icon_url, custom_icon_text)
 
             else:
                 set_game(do_game_title, None, coverImage, startTime, do_custom_state, custom_state, do_custom_icon, custom_icon_url, custom_icon_text)
 
         # if the game has changed, restart the rich presence client with that new app ID
-        if oldGameName != gameName and gameName != None:
+        if (oldGameName != gameName and gameName != None) or (app_id == DEFAULT_APP_ID and scraped == True):
             startTime = round(time())
             print(f"game changed to \"{gameName}\"")
 
             app_id = get_game_id(gameName)
+            if app_id == DEFAULT_APP_ID and scraped == True:
+                app_id = SECONDARY_APP_ID
+
             startTime = round(time())
 
             RPC.close()

package.json

@@ -1,13 +1,14 @@
 {
-    "name": "steam-presence-on-discord",
-    "version": "1.3",
+    "name": "steam-presence",
+    "version": "1.4.1",
     "description": "A script which takes the game you're playing on steam and displays it on discord",
     "author": "JustTemmie",
-    "repository": "JustTemmie/steam-presence-on-discord",
+    "repository": "JustTemmie/steam-presence",
     "license": "MIT",
     "main": "main.py",
     "dependencies": {
         "python-steamgriddb": ">=1.0.5",
-        "pypresence": ">=4.2.1"
+        "pypresence": ">=4.2.1",
+        "beautifulsoup4": ">=4.7.0"
     }
 }