From 86ea6158696194a0ce6ebcf5515646a535dde6ef Mon Sep 17 00:00:00 2001 From: Deeptendu Santra Date: Thu, 1 Oct 2020 12:03:29 +0530 Subject: [PATCH 1/6] Removed Laplace from the list of fit.md --- docs/src/fit.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/src/fit.md b/docs/src/fit.md index 24e8ee1dc4..2a376e0d0b 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -47,7 +47,6 @@ The `fit_mle` method has been implemented for the following distributions: - [`Normal`](@ref) - [`Gamma`](@ref) - [`Geometric`](@ref) -- [`Laplace`](@ref) - [`Pareto`](@ref) - [`Poisson`](@ref) - [`Rayleigh`](@ref) From 167c684d90465e30adb8566e2f3537311da1f594 Mon Sep 17 00:00:00 2001 From: Deeptendu Santra Date: Sat, 17 Oct 2020 02:09:16 +0530 Subject: [PATCH 2/6] Added note for weighted fit_mle --- docs/src/fit.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/src/fit.md b/docs/src/fit.md index 2a376e0d0b..9ee23c3746 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -47,6 +47,7 @@ The `fit_mle` method has been implemented for the following distributions: - [`Normal`](@ref) - [`Gamma`](@ref) - [`Geometric`](@ref) +- [`Laplace`](@ref) - [`Pareto`](@ref) - [`Poisson`](@ref) - [`Rayleigh`](@ref) @@ -71,7 +72,9 @@ fit_mle(Categorical, k, x, w) fit_mle(Categorical, x) # equivalent to fit_mle(Categorical, max(x), x) fit_mle(Categorical, x, w) ``` +!!! note + Laplace distribution currently does not support weighted fit_mle. ## Sufficient Statistics For many distributions, estimation can be based on (sum of) sufficient statistics computed from a dataset. To simplify implementation, for such distributions, we implement `suffstats` method instead of `fit_mle` directly: From 14fc8cbdc22ca79292a14e5cb5afb9e12f15cf20 Mon Sep 17 00:00:00 2001 From: Deeptendu Santra Date: Sat, 17 Oct 2020 02:14:47 +0530 Subject: [PATCH 3/6] change note to warning --- docs/src/fit.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/fit.md b/docs/src/fit.md index 9ee23c3746..c3e2a0bbaf 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -72,9 +72,9 @@ fit_mle(Categorical, k, x, w) fit_mle(Categorical, x) # equivalent to fit_mle(Categorical, max(x), x) fit_mle(Categorical, x, w) ``` -!!! note +!!! warning - Laplace distribution currently does not support weighted fit_mle. + Laplace distribution currently does not support weighted fit_mle. ## Sufficient Statistics For many distributions, estimation can be based on (sum of) sufficient statistics computed from a dataset. To simplify implementation, for such distributions, we implement `suffstats` method instead of `fit_mle` directly: From 3f7ac725fb51ff55a17fb06be0ce06304a6f968c Mon Sep 17 00:00:00 2001 From: Deeptendu Santra Date: Sat, 17 Oct 2020 02:18:35 +0530 Subject: [PATCH 4/6] minor fix. --- docs/src/fit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/fit.md b/docs/src/fit.md index c3e2a0bbaf..280d646123 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -74,7 +74,7 @@ fit_mle(Categorical, x, w) ``` !!! warning - Laplace distribution currently does not support weighted fit_mle. + Laplace distribution currently does not support weighted `fit_mle`. ## Sufficient Statistics For many distributions, estimation can be based on (sum of) sufficient statistics computed from a dataset. To simplify implementation, for such distributions, we implement `suffstats` method instead of `fit_mle` directly: From 16a4c4ba80e35a80f71946970a2191ae225a95b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Besan=C3=A7on?= Date: Sat, 8 May 2021 13:21:58 +0200 Subject: [PATCH 5/6] Update docs/src/fit.md --- docs/src/fit.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/src/fit.md b/docs/src/fit.md index 280d646123..fc48365f14 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -75,6 +75,7 @@ fit_mle(Categorical, x, w) !!! warning Laplace distribution currently does not support weighted `fit_mle`. + ## Sufficient Statistics For many distributions, estimation can be based on (sum of) sufficient statistics computed from a dataset. To simplify implementation, for such distributions, we implement `suffstats` method instead of `fit_mle` directly: From c4e4f3a2c4d2535bbe97535906832b24842da06d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Besan=C3=A7on?= Date: Sat, 8 May 2021 13:22:14 +0200 Subject: [PATCH 6/6] Update docs/src/fit.md --- docs/src/fit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/fit.md b/docs/src/fit.md index fc48365f14..a55f191466 100644 --- a/docs/src/fit.md +++ b/docs/src/fit.md @@ -47,7 +47,7 @@ The `fit_mle` method has been implemented for the following distributions: - [`Normal`](@ref) - [`Gamma`](@ref) - [`Geometric`](@ref) -- [`Laplace`](@ref) +- [`Laplace`](@ref) - [`Pareto`](@ref) - [`Poisson`](@ref) - [`Rayleigh`](@ref)