Use min in automerge-unit tests
#637
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and pass `--project` flag to `setup-julia` so it can parse `min`. in #632 we tried `min` but I didn't realize `project` needed to be passed to setup-julia (not just julia-test)
| - ubuntu-latest | ||
| version: | ||
| - '1.10' # earliest supported version | ||
| - 'min' # earliest supported version |
Member
There was a problem hiding this comment.
Suggested change
| - 'min' # earliest supported version | |
| - 'min' # earliest supported version | |
| - 'lts' # LTS |
Member
Author
There was a problem hiding this comment.
that will run 1.10 twice though
Suggested change
| - 'min' # earliest supported version | |
| - 'min' # earliest supported version | |
| # - 'lts' # LTS - to be uncommented once min is not the same as LTS |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (42.99%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
===========================================
- Coverage 76.34% 42.99% -33.35%
===========================================
Files 29 29
Lines 1750 1742 -8
===========================================
- Hits 1336 749 -587
- Misses 414 993 +579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and pass
--projectflag tosetup-juliaso it can parsemin.in #632 we tried
minbut I didn't realizeprojectneeded to be passed to setup-julia (not just julia-test)