Skip to content

C++11 std::string_view mis-detected as C++03 #1374

@eschnett

Description

@eschnett

This logic in BinaryBuilder.jl

# Otherwise, if we still have `std::string`'s or `std::list`'s in there, it's implicitly a
# `cxx03` binary, even though we don't have a __cxx03 namespace or something. Mark it.
if any(occursin("std::string", c) || occursin("std::basic_string", c) ||
occursin("std::list", c) for c in symbol_names)
return "cxx03"
end

triggers on C++11 std::string_view: While std::string maps to std::__cxx11::string internally, std::string_view maps to std::basic_string_view, and the regex matches. This leads to false positives.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions