[AutoBuild] Filter out non-build deps before calling setup_dependencies (#1209)

Author: giordano

Manifest.toml

@@ -1,7 +1,7 @@
 name = "BinaryBuilder"
 uuid = "12aac903-9f7c-5d81-afc2-d9565ea332ae"
 authors = ["Elliot Saba <staticfloat@gmail.com>"]
-version = "0.5.4"
+version = "0.5.5"
 
 [deps]
 ArgParse = "c7e460c6-2fb9-53a9-8c5b-16f535851c63"
@@ -33,7 +33,7 @@ ghr_jll = "07c12ed4-43bc-5495-8a2a-d5838ef8d533"
 
 [compat]
 ArgParse = "1.1"
-BinaryBuilderBase = "1.10"
+BinaryBuilderBase = "1.12"
 GitHub = "5.1"
 HTTP = "0.8, 0.9"
 JLD2 = "0.1.6, 0.2, 0.3, 0.4"

Project.toml

@@ -330,6 +330,8 @@ dependencies = [
 
 * [`Dependency`](@ref) specify a JLL package that is necessary to build and load
   the current builder.  Binaries for the target platform will be installed;
+* [`RuntimeDependency`](@ref): a JLL package that is necessary only at runtime.  Its
+  artifact will not be installed in the prefix during the build.
 * [`BuildDependency`](@ref) is a JLL package necessary only to build the current
   package, but not to load it.  This dependency will install binaries for the
   target platforms and will not be added to the list of the dependencies of the
@@ -338,11 +340,11 @@ dependencies = [
   install binaries for the host system.  This kind of dependency is usually
   added to provide some binary utilities to run during the build process.
 
-The argument of `Dependency`, `BuildDependency`, and `HostBuildDependency` can
-also be a `Pkg.PackageSpec`, with which you can specify more details about the
-dependency, like a version number, or also a non-registered package.  Note that
-in Yggdrasil only JLL packages in the [General
-registry](https://github.com/JuliaRegistries/General) can be accepted.
+The argument of `Dependency`, `RuntimeDependency`, `BuildDependency`, and
+`HostBuildDependency` can also be a `Pkg.PackageSpec`, with which you can
+specify more details about the dependency, like a version number, or also a
+non-registered package.  Note that in Yggdrasil only JLL packages in the
+[General registry](https://github.com/JuliaRegistries/General) can be accepted.
 
 The dependencies for the target system (`Dependency` and `BuildDependency`) will
 be installed under `${prefix}` within the build environment, while the
@@ -358,7 +360,7 @@ Examples of builders that depend on other binaries include:
   depends on `Xorg_libxcb_jll`, and `Xorg_xtrans_jll` at build- and run-time,
   and on `Xorg_xorgproto_jll` and `Xorg_util_macros_jll` only at build-time.
 
-### Platform-dependent dependencies
+### Platform-specific dependencies
 
 By default, all dependencies are used for all platforms, but there are some
 cases where a package requires some dependencies only on some platforms.  You

docs/src/building.md

@@ -785,7 +785,7 @@ function autobuild(dir::AbstractString,
             verbose=verbose,
         )
         setup_deps(f, prefix, dependencies, platform, verbose) =
-            setup_dependencies(prefix, Pkg.Types.PackageSpec[getpkg(d) for d in filter_platforms(dependencies, platform) if f(d)], platform; verbose)
+            setup_dependencies(prefix, Pkg.Types.PackageSpec[getpkg(d) for d in filter_platforms(dependencies, platform) if f(d) && is_build_dependency(d)], platform; verbose)
         host_artifact_paths = setup_deps(is_host_dependency, prefix, dependencies, default_host_platform, verbose)
         target_artifact_paths = setup_deps(is_target_dependency, prefix, dependencies, concrete_platform, verbose)
 

src/AutoBuild.jl

@@ -22,7 +22,7 @@ export AnyPlatform
 export Product, LibraryProduct, FileProduct, ExecutableProduct, FrameworkProduct, satisfied,
        locate, write_deps_file, variable_name
 # BinaryBuilderBase/src/Dependency.jl
-export Dependency, BuildDependency, HostBuildDependency
+export Dependency, RuntimeDependency, BuildDependency, HostBuildDependency
 # BinaryBuilderBase/src/Sources.jl
 export ArchiveSource, FileSource, GitSource, DirectorySource
 # Auditor.jl