Fix location of definition of const (#116)

Author: dkarrasch

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "0.8.16"
+version = "0.8.17"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/ldiv.jl

@@ -135,6 +135,7 @@ macro _layoutldiv(Typ)
         LinearAlgebra.ldiv!(A::Factorization, x::$Typ; kwds...) = ArrayLayouts.ldiv!(A,x; kwds...)
         LinearAlgebra.ldiv!(A::LU, x::$Typ; kwds...) = ArrayLayouts.ldiv!(A,x; kwds...)
         LinearAlgebra.ldiv!(A::Cholesky, x::$Typ; kwds...) = ArrayLayouts.ldiv!(A,x; kwds...)
+        LinearAlgebra.ldiv!(A::LinearAlgebra.QRCompactWY, x::$Typ; kwds...) = ArrayLayouts.ldiv!(A,x; kwds...)
 
         LinearAlgebra.ldiv!(A::Bidiagonal, B::$Typ; kwds...) = ArrayLayouts.ldiv!(A,B; kwds...)
 

src/mul.jl

@@ -118,8 +118,6 @@ mul!(dest::AbstractArray, A::AbstractArray, B::AbstractArray, α::Number, β::Nu
 
 broadcastable(M::Mul) = M
 
-const FlexibleLeftQs = Union{LinearAlgebra.HessenbergQ, LinearAlgebra.QRCompactWYQ, LinearAlgebra.QRPackedQ}
-
 macro veclayoutmul(Typ)
     ret = quote
         (*)(A::AbstractMatrix, B::$Typ) = ArrayLayouts.mul(A,B)
@@ -139,6 +137,7 @@ macro veclayoutmul(Typ)
         ret = quote
             $ret
 
+            const FlexibleLeftQs = Union{LinearAlgebra.HessenbergQ, LinearAlgebra.QRCompactWYQ, LinearAlgebra.QRPackedQ}
             # disambiguation for flexible left-mul Qs
             (*)(A::FlexibleLeftQs, B::$Typ) = ArrayLayouts.mul(A,B)
             # flexible right-mul/adjoint left-mul Qs
@@ -213,6 +212,7 @@ macro layoutmul(Typ)
         ret = quote
             $ret
 
+            const FlexibleLeftQs = Union{LinearAlgebra.HessenbergQ, LinearAlgebra.QRCompactWYQ, LinearAlgebra.QRPackedQ}
             # disambiguation for flexible left-mul/adjoint right-mul Qs
             (*)(A::FlexibleLeftQs, B::$Typ) = ArrayLayouts.mul(A,B)
             (*)(A::$Typ, B::LinearAlgebra.AdjointQ{<:Any,<:FlexibleLeftQs}) = ArrayLayouts.mul(A,B)

test/test_layoutarray.jl

@@ -129,8 +129,16 @@ MemoryLayout(::Type{MyVector}) = DenseColumnMajor()
 
             @testset "ldiv!" begin
                 c = MyVector(randn(5))
-                @test_broken ldiv!(lu(A), MyVector(copy(c))) ≈ A \ c
-                @test_throws ErrorException ldiv!(qr(A), MyVector(copy(c)))
+                if VERSION < v"1.9-"
+                    @test_broken ldiv!(lu(A), MyVector(copy(c))) ≈ A \ c
+                else
+                    @test ldiv!(lu(A), MyVector(copy(c))) ≈ A \ c
+                end
+                if VERSION < v"1.9-" || VERSION >= v"1.10-"
+                    @test_throws ErrorException ldiv!(qr(A), MyVector(copy(c)))
+                else
+                    @test_throws MethodError ldiv!(qr(A), MyVector(copy(c)))
+                end
                 @test_throws ErrorException ldiv!(eigen(randn(5,5)), c)
                 @test ArrayLayouts.ldiv!(svd(A.A), copy(c)) ≈ ArrayLayouts.ldiv!(similar(c), svd(A.A), c) ≈ A \ c 
                 if VERSION ≥ v"1.8"