Multiplication with Triangular(::AdjOrTrans) (#159)

* Multiplication with Triangular(::AdjOrTrans)

* Update ArrayLayouts.jl

* Call lmul! from rmul!

* Update triangular.jl

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "1.1.0"
+version = "1.1.1"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/ArrayLayouts.jl

@@ -175,6 +175,7 @@ macro layoutmatrix(Typ)
         ArrayLayouts.@layoutldiv $Typ
         ArrayLayouts.@layoutmul $Typ
         ArrayLayouts.@layoutlmul $Typ
+        ArrayLayouts.@layoutrmul $Typ
         ArrayLayouts.@layoutfactorizations $Typ
         ArrayLayouts.@layoutgetindex $Typ
     end)

src/lmul.jl

@@ -115,6 +115,16 @@ macro layoutlmul(Typ)
         ArrayLayouts.@_layoutlmul UnitUpperTriangular{T, <:$Typ{T}} where T
         ArrayLayouts.@_layoutlmul LowerTriangular{T, <:$Typ{T}} where T
         ArrayLayouts.@_layoutlmul UnitLowerTriangular{T, <:$Typ{T}} where T
+
+        ArrayLayouts.@_layoutlmul UpperTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul UnitUpperTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul LowerTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul UnitLowerTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+
+        ArrayLayouts.@_layoutlmul UpperTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul UnitUpperTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul LowerTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutlmul UnitLowerTriangular{T, <:Transpose{T,<:$Typ{T}}} where T         
     end)
 end
 
@@ -131,5 +141,15 @@ macro layoutrmul(Typ)
         ArrayLayouts.@_layoutrmul UnitUpperTriangular{T, <:$Typ{T}} where T
         ArrayLayouts.@_layoutrmul LowerTriangular{T, <:$Typ{T}} where T
         ArrayLayouts.@_layoutrmul UnitLowerTriangular{T, <:$Typ{T}} where T
+
+        ArrayLayouts.@_layoutrmul UpperTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul UnitUpperTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul LowerTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul UnitLowerTriangular{T, <:Adjoint{T,<:$Typ{T}}} where T
+
+        ArrayLayouts.@_layoutrmul UpperTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul UnitUpperTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul LowerTriangular{T, <:Transpose{T,<:$Typ{T}}} where T
+        ArrayLayouts.@_layoutrmul UnitLowerTriangular{T, <:Transpose{T,<:$Typ{T}}} where T        
     end)
 end

src/triangular.jl

@@ -196,7 +196,7 @@ BLAS.trmm!('R', 'L', 'C', UNIT, one(T), triangulardata(A)', x)
 end
 
 
-materialize!(M::MatRmulMat{<:AbstractStridedLayout,<:TriangularLayout}) = LinearAlgebra.rmul!(M.A, M.B)
+materialize!(M::MatRmulMat{<:AbstractStridedLayout,<:TriangularLayout}) = lmul!(M.B', M.A')'
 
 
 ########