Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No test for bitarray.jl #1146

Open
inkydragon opened this issue Dec 11, 2024 · 2 comments · Fixed by #1148
Open

No test for bitarray.jl #1146

inkydragon opened this issue Dec 11, 2024 · 2 comments · Fixed by #1148

Comments

@inkydragon
Copy link
Member

I find it odd that bitarray is not tested at all.
https://app.codecov.io/gh/JuliaLang/LinearAlgebra.jl/blob/master/src%2Fbitarray.jl

After some searching, the corresponding tests are currently in julialang/julia
https://github.com/JuliaLang/julia/blob/d269d7d375827a0279dc1fee7bb24c9418f06f03/test/bitarray.jl#L1644-L1705

We might migrate them over here.
@KristofferC
Copy link
Member

We might migrate them over here.

Sounds like a good idea

@KristofferC KristofferC mentioned this issue Dec 11, 2024
Merged
KristofferC added a commit that referenced this issue Dec 12, 2024
@KristofferC
port bitarray tests to LinearAlgebra.jl (#1148)
ade3654 
Fixes #1146

Co-authored-by: KristofferC <[email protected]>
@KristofferC
Copy link
Member

I moved the tests but I am not sure that actually fixed the coverage...

@KristofferC KristofferC reopened this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port bitarray tests to LinearAlgebra.jl JuliaLang/LinearAlgebra.jl
2 participants
@KristofferC @inkydragon