Add platform-specific linker flags (#74)

Author: xlxs4

src/linking.jl

@@ -109,6 +109,17 @@ function link_products(recipe::LinkRecipe)
         end
         # Link in the whole archive and user-provided objects, then undo WHOLE_ARCHIVE
         cmd2 = `$cmd2 -Wl,$(Base.Linking.WHOLE_ARCHIVE) $(image_recipe.img_path) $(image_recipe.extra_objects...) -Wl,$(Base.Linking.NO_WHOLE_ARCHIVE) $(julia_libs)`
+        # Platform-specific linker flags
+        lib_name = basename(recipe.outname)
+        if Sys.iswindows()
+            lib_basename, _ = splitext(lib_name)
+            import_lib_path = joinpath(dirname(recipe.outname), lib_basename * ".dll.a")
+            cmd2 = `$cmd2 -Wl,--out-implib=$(import_lib_path)`
+        elseif Sys.isapple()
+            cmd2 = `$cmd2 -Wl,-install_name,@rpath/$(lib_name)`
+        elseif Sys.islinux()
+            cmd2 = `$cmd2 -Wl,-soname,$(lib_name)`
+        end
         image_recipe.verbose && println("Running: $cmd2")
         run(cmd2)
     catch e

test/programatic.jl

@@ -114,6 +114,59 @@
             @test occursin("42", out)
         end
     end
+
+    # https://github.com/JuliaLang/JuliaC.jl/pull/74
+    @testset "Library has SONAME (Linux)" begin
+        if Sys.islinux()
+            outdir = mktempdir()
+            libname = "libhassonametest"
+            libout = joinpath(outdir, libname)
+            link = JuliaC.LinkRecipe(image_recipe=img_lib, outname=libout)
+            JuliaC.link_products(link)
+            bun = JuliaC.BundleRecipe(link_recipe=link, output_dir=outdir)
+            JuliaC.bundle_products(bun)
+
+            soname = libname * "." * Base.BinaryPlatforms.platform_dlext()
+            libpath = joinpath(outdir, "lib", soname)
+            actual_soname = readchomp(`$(Patchelf_jll.patchelf()) --print-soname $(libpath)`)
+            @test actual_soname == soname
+        end
+    end
+
+    # https://github.com/JuliaLang/JuliaC.jl/pull/74
+    @testset "Library has install_name (MacOS)" begin
+        if Sys.isapple()
+            outdir = mktempdir()
+            libname = "libhasinstallnametest"
+            libout = joinpath(outdir, libname)
+            link = JuliaC.LinkRecipe(image_recipe=img_lib, outname=libout)
+            JuliaC.link_products(link)
+            bun = JuliaC.BundleRecipe(link_recipe=link, output_dir=outdir)
+            JuliaC.bundle_products(bun)
+
+            dylibname = libname * "." * Base.BinaryPlatforms.platform_dlext()
+            libpath = joinpath(outdir, "lib", dylibname)
+            # otool -D prints filename on first line, install_name on second
+            install_name = split(readchomp(`otool -D $(libpath)`), '\n')[end]
+            @test install_name == "@rpath/$(dylibname)"
+        end
+    end
+
+    # https://github.com/JuliaLang/JuliaC.jl/pull/74
+    @testset "Library has import library (Windows)" begin
+        if Sys.iswindows()
+            outdir = mktempdir()
+            libname = "libhasimplibtest"
+            libout = joinpath(outdir, libname)
+            link = JuliaC.LinkRecipe(image_recipe=img_lib, outname=libout)
+            JuliaC.link_products(link)
+            bun = JuliaC.BundleRecipe(link_recipe=link, output_dir=outdir)
+            JuliaC.bundle_products(bun)
+
+            implibpath = joinpath(outdir, libname * ".dll.a")
+            @test isfile(implibpath)
+        end
+    end
 end
 
 @testset "Programmatic binary (trim)" begin