From 46bef613a6138b08df174c92e38802632275bd42 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Thu, 24 Aug 2023 22:04:29 -0400 Subject: [PATCH 1/2] For some stdlibs, it is expected that the stdlib version number won't match the Julia version number --- src/bump-stdlibs.jl | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl index e458079..964f636 100644 --- a/src/bump-stdlibs.jl +++ b/src/bump-stdlibs.jl @@ -143,6 +143,21 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) julia_version = Base.VersionNumber(read("VERSION", String)) version_match = stdlib_version isa VersionNumber && Base.thispatch(julia_version) === Base.thispatch(stdlib_version) url_for_diff = chopsuffix(git_url_markdown, ".git") + # Some external stdlibs intentionally have + # version numbers that don't match the + # Julia version number: + known_rogue_versioners = [ + "Downloads", + ] + if version_match + version_match_statement = "" + else + if stdlib.name in known_rogue_versioners + version_match_statement = "(It's okay that it doesn't match)" + else + version_match_statement = "(Does not match)" + end + end pr_body_lines = String[ "Stdlib: $(stdlib.name)", "URL: $(git_url_markdown)", @@ -151,7 +166,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) "Old commit: $(stdlib_current_commit_in_upstream_short)", "New commit: $(stdlib_latest_commit_short)", "Julia version: $(julia_version)", - "$(stdlib.name) version: $(stdlib_version)$(version_match ? "" : " (Does not match)")", + "$(stdlib.name) version: $(stdlib_version)$(version_match_statement)", "Bump invoked by: $(bumpstdlibs_sender_ping)", "Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)", "", From 4bd5dec7b7eb71ecaf8403f49a43a4c557cd31c1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Fri, 25 Aug 2023 15:54:59 -0400 Subject: [PATCH 2/2] Add DelimitedFiles --- src/bump-stdlibs.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bump-stdlibs.jl b/src/bump-stdlibs.jl index 964f636..71ac971 100644 --- a/src/bump-stdlibs.jl +++ b/src/bump-stdlibs.jl @@ -147,6 +147,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State) # version numbers that don't match the # Julia version number: known_rogue_versioners = [ + "DelimitedFiles", "Downloads", ] if version_match