Skip to content

Conversation

@csvance
Copy link
Collaborator

@csvance csvance commented Dec 18, 2025

After server ends the stream with END_STREAM streaming channels/tasks were not being closed.
Properly clean these up in cleanup_request which is called after curl signals CURLMSG_DONE

Fixes: #85

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (1943d06) to head (a5f3c7b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Curl.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   83.39%   83.45%   +0.05%     
==========================================
  Files           7        7              
  Lines         554      556       +2     
==========================================
+ Hits          462      464       +2     
  Misses         92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance csvance merged commit 7ff0517 into main Dec 18, 2025
13 checks passed
@csvance csvance deleted the fix-server-streaming-hang branch December 19, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When streaming server side close, client hangs

3 participants