Raise warnings if any data in unknown/reserved subsystem metadata regions #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks okay, I fixed a merge conflict. Shall we merge? |
Contributor
Author
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple update to log a warning if someone encounters MCOS metadata that we don't know about. This will help us in our development efforts to support MCOS objects. Fixes #226
A basic summary of metadata regions of unknown purpose below:
subsys._u6_metadata- this is usually emptysubsys._u7_metadata- this is usually all zerossubsys._c3- this contains data shared between all instances of a class. We don't know what the data is yetsubsys.class_id_metadata- This is a block of 4 numbers(A, B, X, X). The X's purpose are unknown.subsys.object_id_metadata- This is a block of 6 numbers(A, X, X, B, C, D). The X's purpose are unknown.Should be ready now