Skip to content

Conversation

@hhaensel
Copy link
Contributor

Currently haskey(::Object) is true for both String and Symbol, but getindex() doesn't get it.

julia> o = JSON.parse("""{"a": "a"}""")
julia> haskey(o, :a)
true
julia> o[:a]
ERROR: MethodError: no method matching find_node_by_key(::JSON.Object{String, Any}, ::Symbol)
The function `find_node_by_key` exists, but no method is defined for this combination of argument types.

This PR fixes that issue.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (7ffcc9d) to head (fc4fede).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/object.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   90.18%   90.05%   -0.14%     
==========================================
  Files           7        7              
  Lines        1345     1347       +2     
==========================================
  Hits         1213     1213              
- Misses        132      134       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit 928a3cc into JuliaIO:master Dec 18, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants