Fix various invalidations #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- '>' and '>=' are already defined by Base in terms of '<' and '<=' - Base already defines a `convert(::T, ::Number)` method using type constructors. Replacing our `convert` method with the relevant constructors doesn't completely fix all the invalidations `convert` caused, but it does help. - `any()`, `all()`, and `Broadcast.broadcasted()` all have default implementations in Base that do the same thing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 94.82% 95.54% +0.72%
==========================================
Files 5 5
Lines 1043 1055 +12
==========================================
+ Hits 989 1008 +19
+ Misses 54 47 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 17, 2025
Contributor
Author
|
Thanks for the review ❤️ Is there any chance we could tag a new release? |
Member
|
Tagged a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert(::T, ::Number)method using type constructors. Replacing ourconvertmethod with the relevant constructors doesn't completely fix all the invalidationsconvertcaused, but it does help.any(),all(),similar(), andBroadcast.broadcasted()all have default implementations in Base that do the same thing.On Julia 1.12 this reduces the total number of invalidations from 7570 to 2005. For CUDA.jl (which depends on SentinelArrays through DataFrames) this reduces the number of invalidations from 17089 to 11175. Discovered when looking into JuliaGPU/CUDA.jl#2982.