🐛 Bug: Releases can become broken after two quick pushes to main again

[JoshuaKGoldberg]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Expected

Pushing two "meaningful" commits -as in, ones that should cause a new package publish- to main should not cause failures. Both should be released in 1-2 packages on npm.

Actual

The saga of #556 -> #862 continues: if two meaningful commits are pushed to main quickly, the release flow of the first one will fail to git push because the second is running.

See the build failures from, in order:

1. fda4ec9
2. b39ae00

Additional Info

I don't yet know how to solve this... but accepting PRs if someone does.

🎁

[xav-ie]

Do you think one of these might be helpful?

• https://github.com/ahmadnassri/action-workflow-queue/tree/master (uses gh actions api to queue for status)
• https://github.com/ben-z/gh-action-mutex/blob/main/rootfs/scripts/unlock.sh (uses git commits to get queue-ing).

I think the first one might be better especially since you said there was some commit issues, so I think that makes the second project not viable.

I am confused by this:

However, the first commit's workflow will always fail if it's behind the main branch in terms of commits! Example from JoshuaKGoldberg/template-typescript-node-package/actions/runs/5292082143/jobs/9578516799:

Changeset:
 M package.json
ERROR To https://github.com/JoshuaKGoldberg/template-typescript-node-package
 * [new tag]         v1.28.25 -> v1.28.25
 ! [rejected]        main -> main (non-fast-forward)
error: failed to push some refs to 'https://github.com/JoshuaKGoldberg/template-typescript-node-package'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Rolling back changes...

---

why would the first workflow get behind? I have not much familiarity with JoshuaKGoldberg/release-it-action@v0.2.2 and the rest of that workflow output is expired

[JoshuaKGoldberg]

why would the first workflow get behind?

I believe it's that the following roughly happens:

1. 🍎 Commit A is checked in and its workflow starts
2. 🍌 Commit B is checked in and its workflow starts
3. 🍎 A creates a commit and tries to push it: ❌ this fails because it's behind commit B

...but it's been a while and I don't remember exactly 😅

familiarity with JoshuaKGoldberg/release-it-action

It's a fairly small action. Most of its logic is in https://github.com/JoshuaKGoldberg/release-it-action/blob/c14150cbf82f3a31fa0a44e6edb9dfd70ae22bb6/src/index.ts. Basically it:

1. Checks if a release needs to happen at all (should-semantic-release)
2. Runs npx release-it

...so basically it's just running npx release-it