fix: update image-size to v2 (#2232)

## PR Checklist

- [x] Addresses an existing open issue: fixes #2231
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Branches off #1948 for some code changes.

This also copies the comment noting that `imageSize` doesn't go through
Bingo's `take()`.

🎁

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Author: JoshuaKGoldberg

package.json

@@ -47,7 +47,7 @@
 		"git-url-parse": "^16.0.1",
 		"github-default-labels": "^0.1.0",
 		"html-to-text": "^9.0.5",
-		"image-size": "^1.2.0",
+		"image-size": "^2.0.0",
 		"input-from-file": "^0.5.4",
 		"input-from-file-json": "^0.5.4",
 		"input-from-script": "^0.5.4",

pnpm-lock.yaml

@@ -2,6 +2,10 @@ import { describe, expect, it, vi } from "vitest";
 
 import { readLogo } from "./readLogo.js";
 
+vi.mock("node:fs/promises", () => ({
+	readFile: vi.fn(() => Promise.resolve(Buffer.from([0]))),
+}));
+
 const mockReadLogoSizing = vi.fn().mockResolvedValue({});
 
 vi.mock("./readLogoSizing.js", () => ({

src/options/readLogo.test.ts

@@ -1,3 +1,5 @@
+import * as fs from "node:fs/promises";
+
 import { readLogoSizing } from "./readLogoSizing.js";
 
 export async function readLogo(getReadme: () => Promise<string>) {
@@ -24,9 +26,14 @@ export async function readLogo(getReadme: () => Promise<string>) {
 		return undefined;
 	}
 
+	// TODO: imageSize does not go through take(input*), making it harder to test.
+	// It takes either a string (fs access) or buffer data (not in bingo-fs).
+	// https://github.com/JoshuaKGoldberg/create-typescript-app/issues/1993
+	const bufferData = await fs.readFile(src);
+
 	return {
 		alt,
 		src,
-		...readLogoSizing(src),
+		...readLogoSizing(bufferData),
 	};
 }

src/options/readLogo.ts

@@ -10,7 +10,7 @@ vi.mock("image-size", () => ({
 	},
 }));
 
-const src = "img.jpg";
+const src = Buffer.from([0]);
 
 describe(readLogoSizing, () => {
 	it("returns undefined when imageSize throws an error", () => {

src/options/readLogoSizing.test.ts

@@ -7,9 +7,7 @@ export interface OptionsLogoSizing {
 	width?: number;
 }
 
-export function readLogoSizing(
-	src: string | Uint8Array,
-): OptionsLogoSizing | undefined {
+export function readLogoSizing(src: Uint8Array): OptionsLogoSizing | undefined {
 	const size = imageSizeSafe(src);
 	if (!size) {
 		return undefined;
@@ -32,7 +30,7 @@ export function readLogoSizing(
 		: { height: (size.height / size.width) * maximum, width: maximum };
 }
 
-function imageSizeSafe(src: string | Uint8Array) {
+function imageSizeSafe(src: Uint8Array) {
 	try {
 		// TODO: imageSize does not go through take(input*), making it harder to test.
 		// It takes either a string (fs access) or buffer data (not in bingo-fs).