Skip to content

Commit 169511f

Browse files
fix(macos): drop codesign_identity:None from py2app options
The py2app version on macos-15 runners rejects codesign_identity with "command 'py2app' has no such option 'codesign_identity'". Setting it to None was already a no-op — signing happens in scripts/macos_sign_and_notarize.sh — so just omit the key entirely. Resolves the only remaining failing check on PR #10 (build job ran as continue-on-error, so PR was already mergeable; this turns the canary green). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 0414f69 commit 169511f

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

setup_py2app.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,10 @@
8282
],
8383
"strip": False,
8484
"optimize": 0,
85-
# We sign in a separate step. py2app's signer is too coarse
86-
# for our entitlements requirements.
87-
"codesign_identity": None,
85+
# Signing is handled by scripts/macos_sign_and_notarize.sh in a
86+
# separate step (py2app's signer is too coarse for our entitlements
87+
# requirements). Omitting codesign_identity entirely — older py2app
88+
# versions reject the option even when set to None.
8889
}
8990

9091
# Architecture: opt-in to universal2 only when explicitly requested

0 commit comments

Comments
 (0)