fix: bug with encoding time types

Author: JonathanWilbur

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [9.0.2]
+
+- Fix bug when encoding `DATE` values having a year less than 1000.
+- Fix bug when encoding `DATE-TIME` values having a year less than 1000.
+- Fix bug when encoding `TIME-OF-DAY` values having hours, minutes, or seconds
+  that are single-digit.
+- Fix bug when encoding `UTCTime` values having a year less than 1000.
+- Fix bug when encoding `GeneralizedTime` values having a year less than 1000.
+
 ## [9.0.1]
 
 - Fix types export

package.json

@@ -48,5 +48,5 @@
         "test": "node --test"
     },
     "types": "./dist/index.d.mts",
-    "version": "9.0.1"
+    "version": "9.0.2"
 }

source/codecs/x690/encoders/encodeDate.mts

@@ -12,7 +12,7 @@ function encodeDate (date: DATE): Uint8Array {
     }
     // NOTE: Using .toISOString() will not work, because it is in UTC time.
     return convertTextToBytes(
-        date.getFullYear().toString()
+        date.getFullYear().toString().padStart(4, "0")
         + (date.getMonth() + 1).toString().padStart(2, "0")
         + date.getDate().toString().padStart(2, "0"),
     );

source/codecs/x690/encoders/encodeDateTime.mts

@@ -12,7 +12,7 @@ function encodeDateTime (value: DATE_TIME): Uint8Array {
     }
     // NOTE: Using .toISOString() will not work, because it is in UTC time.
     return convertTextToBytes(
-        value.getFullYear().toString()
+        value.getFullYear().toString().padStart(4, "0")
         + (value.getMonth() + 1).toString().padStart(2, "0")
         + value.getDate().toString().padStart(2, "0")
         + value.getHours().toString().padStart(2, "0")

source/codecs/x690/encoders/encodeGeneralizedTime.mts

@@ -3,7 +3,7 @@ import convertTextToBytes from "../../../utils/convertTextToBytes.mjs";
 
 export default
 function encodeGeneralizedTime (value: GeneralizedTime): Uint8Array {
-    const year: string = value.getUTCFullYear().toString();
+    const year: string = value.getUTCFullYear().toString().padStart(4, "0");
     const month: string = (value.getUTCMonth() + 1).toString().padStart(2, "0");
     const day: string = value.getUTCDate().toString().padStart(2, "0");
     const hour: string = value.getUTCHours().toString().padStart(2, "0");

source/codecs/x690/encoders/encodeTimeOfDay.mts

@@ -13,5 +13,9 @@ import convertTextToBytes from "../../../utils/convertTextToBytes.mjs";
  */
 export default
 function encodeTimeOfDay (time: TIME_OF_DAY): Uint8Array {
-    return convertTextToBytes(`${time.getHours()}${time.getMinutes()}${time.getSeconds()}`);
+    return convertTextToBytes(
+        time.getHours().toString().padStart(2, "0")
+        + time.getMinutes().toString().padStart(2, "0")
+        + time.getSeconds().toString().padStart(2, "0")
+    );
 }

source/codecs/x690/encoders/encodeUTCTime.mts

@@ -4,7 +4,7 @@ import convertTextToBytes from "../../../utils/convertTextToBytes.mjs";
 export default
 function encodeUTCTime (value: UTCTime): Uint8Array {
     let year: string = value.getUTCFullYear().toString();
-    year = (year.substring(year.length - 2, year.length)); // Will fail if you supply a <2 digit date.
+    year = (year.substring(year.length - 2, year.length)).padStart(2, "0"); // Will fail if you supply a <2 digit date.
     const month: string = (value.getUTCMonth() + 1).toString().padStart(2, "0");
     const day: string = value.getUTCDate().toString().padStart(2, "0");
     const hour: string = value.getUTCHours().toString().padStart(2, "0");