Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the URLs of the PluginClassLoader instead of just the plugin jar #3

Open
JohnnyJayJay opened this issue Aug 26, 2020 · 0 comments
Open

Use the URLs of the PluginClassLoader instead of just the plugin jar #3

JohnnyJayJay opened this issue Aug 26, 2020 · 0 comments

Comments

@JohnnyJayJay
Copy link
Owner

NmsClassLoader currently just iterates over the contents of the plugin jar and only adjusts the classes contained there. This means that other JARs or classes in the classpath of the PluginClassLoader are ignored.

It should be considered to iterate over the URLs of the PluginClassLoader and preload all appropriate classes.

I still have to look into the consequences of this in terms of duplicate class loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnnyJayJay