[Gradle] Include shared-test source sets dependencies to IDE resolver

It can happen that main source sets dont't have this dependency.
As it was previously assumed.

i.e. platform-only dependencies still should not be included as they
can break on PSM artifact resolution.

^KT-75605 Verification Pending

Author: antohaby

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/MppIdeDependencyResolutionIT.kt

@@ -18,6 +18,7 @@ import org.jetbrains.kotlin.gradle.idea.tcs.extras.*
 import org.jetbrains.kotlin.gradle.idea.testFixtures.tcs.*
 import org.jetbrains.kotlin.gradle.testbase.*
 import org.jetbrains.kotlin.gradle.util.*
+import org.jetbrains.kotlin.gradle.util.kotlinStdlibDependencies
 import org.jetbrains.kotlin.konan.target.HostManager
 import org.jetbrains.kotlin.konan.target.KonanTarget.*
 import org.junit.AssumptionViolatedException
@@ -502,6 +503,8 @@ class MppIdeDependencyResolutionIT : KGPBaseTest() {
 
             resolveIdeDependencies { dependencies ->
                 assertNoCompileTasksGotExecuted()
+                dependencies.assertResolvedDependenciesOnly()
+
                 dependencies["jvmMain"].getOrFail(
                     projectArtifactDependency(
                         Regular,
@@ -536,6 +539,8 @@ class MppIdeDependencyResolutionIT : KGPBaseTest() {
 
             resolveIdeDependencies { dependencies ->
                 assertNoCompileTasksGotExecuted()
+                dependencies.assertResolvedDependenciesOnly()
+
                 assertOutputDoesNotContain("e: org.jetbrains.kotlin.gradle.plugin.ide") // FIXME: KT-74976 Add strict mode for IDE dependency resolvers
                 val expectedJvmDependencies = listOf(
                     jetbrainsAnnotationDependencies,
@@ -567,6 +572,54 @@ class MppIdeDependencyResolutionIT : KGPBaseTest() {
         }
     }
 
+    @GradleTest
+    fun `KT-75605 dependency to kmp project from test source set`(gradleVersion: GradleVersion) {
+        project("base-kotlin-multiplatform-library", gradleVersion) {
+            includeOtherProjectAsSubmodule("base-kotlin-multiplatform-library", newSubmoduleName = "test-utils") {
+                buildScriptInjection {
+                    kotlinMultiplatform.apply {
+                        jvm()
+                        linuxX64()
+                        linuxArm64()
+                        iosX64()
+                    }
+                }
+            }
+
+            buildScriptInjection {
+                kotlinMultiplatform.apply {
+                    jvm()
+                    linuxX64()
+                    linuxArm64()
+                    iosX64()
+
+                    sourceSets.commonTest.dependencies {
+                        api(project(":test-utils"))
+                    }
+                }
+            }
+
+            resolveIdeDependencies { dependencies ->
+                assertNoCompileTasksGotExecuted()
+                dependencies.assertResolvedDependenciesOnly()
+
+                dependencies["commonTest"].assertMatches(
+                    friendSourceDependency(":/commonMain"),
+                    regularSourceDependency(":test-utils/commonMain"),
+                    kotlinStdlibDependencies
+                )
+                dependencies["nativeTest"].assertMatches(
+                    friendSourceDependency(":/commonMain"),
+                    friendSourceDependency(":/nativeMain"),
+                    dependsOnDependency(":/commonTest"),
+                    regularSourceDependency(":test-utils/commonMain"),
+                    regularSourceDependency(":test-utils/nativeMain"),
+                    kotlinNativeDistributionDependencies, // kotlin-stdlib is part of native distribution
+                )
+            }
+        }
+    }
+
     private fun Iterable<IdeaKotlinDependency>.cinteropDependencies() =
         this.filterIsInstance<IdeaKotlinBinaryDependency>().filter {
             it.klibExtra?.isInterop == true && !it.isNativeStdlib && !it.isNativeDistribution

libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/ide/dependencyResolvers/IdeVisibleMultiplatformSourceDependencyResolver.kt

@@ -14,7 +14,7 @@ import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet
 import org.jetbrains.kotlin.gradle.plugin.ide.IdeDependencyResolver
 import org.jetbrains.kotlin.gradle.plugin.ide.IdeaKotlinProjectCoordinates
 import org.jetbrains.kotlin.gradle.plugin.mpp.MetadataDependencyResolution
-import org.jetbrains.kotlin.gradle.plugin.mpp.internal.psmArtifactsForAllDependencies
+import org.jetbrains.kotlin.gradle.plugin.mpp.internal.psmArtifactsForAllDependenciesFromSharedSourceSets
 import org.jetbrains.kotlin.gradle.plugin.mpp.projectDependency
 import org.jetbrains.kotlin.gradle.plugin.sources.DefaultKotlinSourceSet
 import org.jetbrains.kotlin.gradle.utils.future
@@ -52,6 +52,6 @@ internal object IdeVisibleMultiplatformSourceDependencyResolver : IdeDependencyR
     }
 
     override fun dependencies(project: Project): Iterable<Any> {
-        return project.future { project.psmArtifactsForAllDependencies() }.getOrThrow()
+        return project.future { project.psmArtifactsForAllDependenciesFromSharedSourceSets() }.getOrThrow()
     }
 }

libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/internal/projectStructureMetadataConfiguration.kt

@@ -14,10 +14,10 @@ import org.jetbrains.kotlin.gradle.plugin.KotlinProjectSetupAction
 import org.jetbrains.kotlin.gradle.plugin.PropertiesProvider.Companion.kotlinPropertiesProvider
 import org.jetbrains.kotlin.gradle.plugin.launch
 import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinUsages
-import org.jetbrains.kotlin.gradle.plugin.mpp.kotlinMetadataCompilations
 import org.jetbrains.kotlin.gradle.plugin.mpp.resolvableMetadataConfiguration
 import org.jetbrains.kotlin.gradle.plugin.sources.InternalKotlinSourceSet
 import org.jetbrains.kotlin.gradle.plugin.sources.internal
+import org.jetbrains.kotlin.gradle.plugin.sources.isSharedSourceSet
 import org.jetbrains.kotlin.gradle.plugin.usageByName
 import org.jetbrains.kotlin.gradle.targets.metadata.locateOrRegisterGenerateProjectStructureMetadataTask
 import org.jetbrains.kotlin.gradle.utils.*
@@ -57,10 +57,11 @@ internal fun InternalKotlinSourceSet.projectStructureMetadataResolvedConfigurati
     }
 }
 
-internal suspend fun Project.psmArtifactsForAllDependencies(): List<FileCollection> {
+internal suspend fun Project.psmArtifactsForAllDependenciesFromSharedSourceSets(): List<FileCollection> {
     if (!kotlinPropertiesProvider.kotlinKmpProjectIsolationEnabled) return emptyList()
-    return multiplatformExtension.kotlinMetadataCompilations().map { compilation ->
-        compilation.defaultSourceSet.internal.projectStructureMetadataResolvedConfiguration().files
+    return multiplatformExtension.sourceSets.mapNotNull { sourceSet ->
+        if (!sourceSet.internal.isSharedSourceSet()) return@mapNotNull null
+        sourceSet.internal.projectStructureMetadataResolvedConfiguration().files
     }
 }
 

libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/InternalKotlinSourceSet.kt

@@ -28,4 +28,6 @@ internal interface InternalKotlinSourceSet : KotlinSourceSet {
 internal suspend fun InternalKotlinSourceSet.awaitPlatformCompilations(): Set<KotlinCompilation<*>> {
     KotlinPluginLifecycle.Stage.AfterFinaliseRefinesEdges.await()
     return compilations.filter { it !is KotlinMetadataCompilation }.toSet()
-}
+}
+
+internal suspend fun InternalKotlinSourceSet.isSharedSourceSet() = awaitPlatformCompilations().size > 1