fix: properly pass BedrockLLMClient timeout setting to BedrockRuntimeClient.HttpClient
#1190
+95
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From initial investigation, it appeared the aws bedrock client was not properly set with the timeout configuration set in the Koog BedrockLLMClient
TeddyCr
changed the title
BedrockLLMClient timeout setting to BedrockRuntimeClient.HttpClient
… validation - `BedrockLLMClient.bedrockClient` is now internal - Configure `callTimeout=settings.requestTimeoutMillis` - Fixed test, now it's testing the actual values. Test maxAttempts and requestTimeouts
kpavlov
force-pushed
the
TeddyCr/minor-pass-bedrock-timeout-to-client
branch
from
b1fd4c2 to
9e8d04c
Compare
Author
devcrocod
reviewed
Nov 26, 2025
...edrock-client/src/jvmMain/kotlin/ai/koog/prompt/executor/clients/bedrock/BedrockLLMClient.kt
Outdated
Show resolved
Hide resolved
…ss-bedrock-timeout-to-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Working with
BedrockLLMClient, I noticed some timeout issues between Koog and bedrock (SocketTimeoutError).It appears, from my understanding and investigation, the timeout config set in the
BedrockLLMClientwas not propagated to theHttpClientof theBedrockRuntimeClient.Breaking Changes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature