[JEWEL-954] Implement ad text in popups #3358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
b0a454a to
9ecf162
Compare
faogustavo
suggested changes
Dec 23, 2025
Collaborator
faogustavo
left a comment
faogustavo
left a comment
There was a problem hiding this comment.
I think that you are missing the LaF styles loading. Also, make sure to get values to match the theme.
For more details in the AdText styles, check the JBUI.CurrentTheme.Advertiser type. You can find its usage to use as baseline on this function public void setAdText(@NotNull @NlsContexts.PopupAdvertisement String s, int alignment)
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
2 times, most recently
from
4356525 to
c4d0b61
Compare
...el/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgePopupAdText.kt
Outdated
Show resolved
Hide resolved
...el/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgePopupAdText.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
c4d0b61 to
91fba7f
Compare
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
2 times, most recently
from
ecf2915 to
20db336
Compare
faogustavo
suggested changes
Jan 2, 2026
Collaborator
faogustavo
left a comment
faogustavo
left a comment
There was a problem hiding this comment.
Don't forget to update API Dumps after updating public apis. Run the 'apiChecks' task in the IDE for it :)
...lone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/styling/IntUiPopupAdTextStyling.kt
Outdated
Show resolved
Hide resolved
...i/int-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/theme/IntUiTheme.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
20db336 to
259bd6b
Compare
faogustavo
suggested changes
Jan 7, 2026
...i/int-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/theme/IntUiTheme.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/DefaultComponentStyling.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
2 times, most recently
from
779db91 to
60a6e3f
Compare
rock3r
suggested changes
Jan 9, 2026
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupAdText.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
60a6e3f to
932f1b6
Compare
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/DefaultComponentStyling.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/styling/PopupAdStyle.kt
Outdated
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
932f1b6 to
2d55cab
Compare
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Menu.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupAd.kt
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
2d55cab to
5df0e71
Compare
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
Show resolved
Hide resolved
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
2 times, most recently
from
1d5e506 to
68e45ea
Compare
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Menu.kt
Show resolved
Hide resolved
faogustavo
approved these changes
Jan 14, 2026
Collaborator
faogustavo
left a comment
faogustavo
left a comment
There was a problem hiding this comment.
Just one minor comment. No blockers
.../jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgePopupAd.kt
Show resolved
Hide resolved
rock3r
reviewed
Jan 14, 2026
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
Show resolved
Hide resolved
rock3r
approved these changes
Jan 15, 2026
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
68e45ea to
0f276f5
Compare
wellingtoncosta
force-pushed
the
wp/implement-popup-ad-text
branch
from
0f276f5 to
a0ba6e9
Compare
.../jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgePopupAd.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new component called
PopupAd, which is designed to be used inside a popup container to give a more informative description to that menu. To use that, you can pass a composable to theadContentparameter introduced to theMenuandPopupContainerpublic API. This API is designed to be simpler as we have inAbstractPopup#setAdTextmethod in the legacy Swing implementation, but in a "composey" way.Additionally, a new
Menussection was introduced to the sample app to showcase menus, including a dedicated sample for menu with ad content.Release notes
PopupAdcomponentPopupAdStyleto theJewelThemeand to theIntUiThemeadContentparameter toPopupContainerandMenucomponents.New features
Note
Adds a bottom "ad" area to popups with a new component and theme styling.
PopupAdcomponent and styling types:PopupAdStyle,PopupAdColors,PopupAdMetrics; exposed viaJewelTheme.popupAdStylePopupMenuandPopupContainergain optionaladContentslot (new overloads); internal menu layout updated to render itDefaultComponentStylingextended withpopupAdStyle;IntUiTheme/JewelThemeupdated to provide/consume itreadPopupAdStyle()and suppliespopupAdStylePopupAddefaultsMenussection (icons +Menus.kt) demonstrating basic, icons, submenus, and ad contentWritten by Cursor Bugbot for commit a0ba6e9. This will update automatically on new commits. Configure here.