Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespace declarations for the Pekko Streams API #244

Closed
Ostrzyciel opened this issue Dec 21, 2024 · 1 comment
Closed

Implement namespace declarations for the Pekko Streams API #244

Ostrzyciel opened this issue Dec 21, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Ostrzyciel
Copy link
Member

Follow-up of #227

In that task I did not implement an API for this in the stream module – the namespace declarations are currently entirely ignored.

I've looked initially into how this could be done, but for now I don't have anything satisfactory. Certainly I wouldn't want the current API to be broken by the changes... and I wouldn't want to introduce a bazillion new method variants. Maybe we could have some kind of flow builders, expanding on the idea already used in DecoderFlow?

In any case, I do not have any use case for this yet (the nanopublication one doesn't use Pekko anyway), so this is a low priority task for now.

@Ostrzyciel Ostrzyciel added the enhancement New feature or request label Dec 21, 2024
@Ostrzyciel Ostrzyciel added this to the 2.5.0 milestone Dec 21, 2024
Ostrzyciel added a commit that referenced this issue Jan 12, 2025
Issue: #244 + more

This is a complete rewrite of the stream encoding API in the jelly-stream module. The previous methods in EncoderFlow and EncoderSource were replaced with flexible builder APIs that give even more flexibility. Notably, now it is possible to include namespace declarations in the streams.
@Ostrzyciel
Copy link
Member Author

Resolved in #256 ... mostly. The rest will be done in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant