Skip to content

Commit 1a1b566

Browse files
committed
Revert "LeaseCandidate alpha -> beta,"
This reverts commit ac7a95e.
1 parent 71622ae commit 1a1b566

File tree

14 files changed

+213
-246
lines changed

14 files changed

+213
-246
lines changed

pkg/controlplane/apiserver/server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ func (c completedConfig) New(name string, delegationTarget genericapiserver.Dele
166166

167167
if utilfeature.DefaultFeatureGate.Enabled(apiserverfeatures.CoordinatedLeaderElection) {
168168
leaseInformer := s.VersionedInformers.Coordination().V1().Leases()
169-
lcInformer := s.VersionedInformers.Coordination().V1beta1().LeaseCandidates()
169+
lcInformer := s.VersionedInformers.Coordination().V1alpha2().LeaseCandidates()
170170
// Ensure that informers are registered before starting. Coordinated Leader Election leader-elected
171171
// and may register informer handlers after they are started.
172172
_ = leaseInformer.Informer()
@@ -177,7 +177,7 @@ func (c completedConfig) New(name string, delegationTarget genericapiserver.Dele
177177
leaseInformer,
178178
lcInformer,
179179
client.CoordinationV1(),
180-
client.CoordinationV1beta1(),
180+
client.CoordinationV1alpha2(),
181181
)
182182
gccontroller := leaderelection.NewLeaseCandidateGC(
183183
client,

pkg/controlplane/controller/leaderelection/election.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ import (
2222

2323
"github.com/blang/semver/v4"
2424
v1 "k8s.io/api/coordination/v1"
25-
v1beta1 "k8s.io/api/coordination/v1beta1"
25+
v1alpha2 "k8s.io/api/coordination/v1alpha2"
2626
"k8s.io/utils/clock"
2727
)
2828

29-
func pickBestLeaderOldestEmulationVersion(candidates []*v1beta1.LeaseCandidate) *v1beta1.LeaseCandidate {
30-
var electee *v1beta1.LeaseCandidate
29+
func pickBestLeaderOldestEmulationVersion(candidates []*v1alpha2.LeaseCandidate) *v1alpha2.LeaseCandidate {
30+
var electee *v1alpha2.LeaseCandidate
3131
for _, c := range candidates {
3232
if !validLeaseCandidateForOldestEmulationVersion(c) {
3333
continue
@@ -39,7 +39,7 @@ func pickBestLeaderOldestEmulationVersion(candidates []*v1beta1.LeaseCandidate)
3939
return electee
4040
}
4141

42-
func pickBestStrategy(candidates []*v1beta1.LeaseCandidate) (v1.CoordinatedLeaseStrategy, error) {
42+
func pickBestStrategy(candidates []*v1alpha2.LeaseCandidate) (v1.CoordinatedLeaseStrategy, error) {
4343
nilStrategy := v1.CoordinatedLeaseStrategy("")
4444
if len(candidates) == 0 {
4545
return nilStrategy, fmt.Errorf("no candidates")
@@ -62,7 +62,7 @@ func pickBestStrategy(candidates []*v1beta1.LeaseCandidate) (v1.CoordinatedLease
6262
return strategy, nil
6363
}
6464

65-
func validLeaseCandidateForOldestEmulationVersion(l *v1beta1.LeaseCandidate) bool {
65+
func validLeaseCandidateForOldestEmulationVersion(l *v1alpha2.LeaseCandidate) bool {
6666
_, err := semver.ParseTolerant(l.Spec.EmulationVersion)
6767
if err != nil {
6868
return false
@@ -71,7 +71,7 @@ func validLeaseCandidateForOldestEmulationVersion(l *v1beta1.LeaseCandidate) boo
7171
return err == nil
7272
}
7373

74-
func getEmulationVersionOrZero(l *v1beta1.LeaseCandidate) semver.Version {
74+
func getEmulationVersionOrZero(l *v1alpha2.LeaseCandidate) semver.Version {
7575
value := l.Spec.EmulationVersion
7676
v, err := semver.ParseTolerant(value)
7777
if err != nil {
@@ -80,7 +80,7 @@ func getEmulationVersionOrZero(l *v1beta1.LeaseCandidate) semver.Version {
8080
return v
8181
}
8282

83-
func getBinaryVersionOrZero(l *v1beta1.LeaseCandidate) semver.Version {
83+
func getBinaryVersionOrZero(l *v1alpha2.LeaseCandidate) semver.Version {
8484
value := l.Spec.BinaryVersion
8585
v, err := semver.ParseTolerant(value)
8686
if err != nil {
@@ -90,7 +90,7 @@ func getBinaryVersionOrZero(l *v1beta1.LeaseCandidate) semver.Version {
9090
}
9191

9292
// -1: lhs better, 1: rhs better
93-
func compare(lhs, rhs *v1beta1.LeaseCandidate) int {
93+
func compare(lhs, rhs *v1alpha2.LeaseCandidate) int {
9494
l := getEmulationVersionOrZero(lhs)
9595
r := getEmulationVersionOrZero(rhs)
9696
result := l.Compare(r)
@@ -115,7 +115,7 @@ func isLeaseExpired(clock clock.Clock, lease *v1.Lease) bool {
115115
lease.Spec.RenewTime.Add(time.Duration(*lease.Spec.LeaseDurationSeconds)*time.Second).Before(currentTime)
116116
}
117117

118-
func isLeaseCandidateExpired(clock clock.Clock, lease *v1beta1.LeaseCandidate) bool {
118+
func isLeaseCandidateExpired(clock clock.Clock, lease *v1alpha2.LeaseCandidate) bool {
119119
currentTime := clock.Now()
120120
return lease.Spec.RenewTime == nil ||
121121
lease.Spec.RenewTime.Add(leaseCandidateValidDuration).Before(currentTime)

0 commit comments

Comments
 (0)