-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery3 compatibility #161
Comments
Thanks @spdawson I have the same issue and your MR is addressing that well, anything blocking it to be merged in master? |
+1 to the the error: Quick fix was dropping back to jquery2. |
+1, and dropping back to jQuery2 is not an option for our use case |
+1 Double Patch request with JQuery 3 |
+1 |
2 similar comments
+1 |
+1 |
I'm having the same issue here |
+1 |
Same here, <%= semantic_form_for([blah, blah], remote: true ) do |f| %> The first Request is Controller#create as JS works but I have the same TypeError: Second Request Controller#create as HTML, because I don't have a handler for HTML 💥 and I can't downgrade jQuery3 :( . |
Remotipart is causing a double PATCH request in my app, following upgrade to version 1.3.0. Similar to #129
One PATCH request contains all expected parameters, and has JavaScript format. The other PATCH has HTML format, and does not contain the attachment file parameter.
Furthermore, the spurious PATCH request does not contain the CSRF authenticity token, which is causing my application to terminate the user session as a security precaution.
I observe that if I revert commit 5366076, then the problem goes away. I am using jQuery 3, which appears to have removed the
complete
method from the jqXHR object.The text was updated successfully, but these errors were encountered: