fix #22814: Command stack shows "Set 1 tags for 0 objects"

GerdP · GerdP · commit 0ba7d5a5d511 · 2024-03-04T07:22:42.000Z
- add check to avoid a no-change-command on the undo/redo stack git-svn-id: https://josm.openstreetmap.de/svn/trunk@19006 0c6e7542-c601-0410-84e7-c038aed88b3b
diff --git a/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java b/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java
@@ -605,6 +605,8 @@ public void performTagEdit() {
             }
             if (key.equals(newkey) && KeyedItem.DIFFERENT_I18N.equals(value))
                 return;
+            if (value != null && key.equals(getEditItem(keys)) && m.size() == 1 && m.containsKey(getEditItem(values)))
+                return; // see #22814: avoid to create a command that wouldn't change anything
             if (key.equals(newkey) || value == null) {
                 UndoRedoHandler.getInstance().add(new ChangePropertyCommand(sel, newkey, value));
                 if (value != null) {

Original file line number	Diff line number	Diff line change
`@@ -605,6 +605,8 @@ public void performTagEdit() {`
`605`	`605`	`}`
`606`	`606`	`if (key.equals(newkey) && KeyedItem.DIFFERENT_I18N.equals(value))`
`607`	`607`	`return;`
	`608`	`+ if (value != null && key.equals(getEditItem(keys)) && m.size() == 1 && m.containsKey(getEditItem(values)))`
	`609`	`+ return; // see #22814: avoid to create a command that wouldn't change anything`
`608`	`610`	`if (key.equals(newkey) \|\| value == null) {`
`609`	`611`	`UndoRedoHandler.getInstance().add(new ChangePropertyCommand(sel, newkey, value));`
`610`	`612`	`if (value != null) {`