Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

ModifyOrderByClientOrderIdAsync should take a string for clientOrderId #31

@kevindarby

Description

@kevindarby

Describe the bug
I believe the IFTXClientTradeApiTrading.ModifyOrderByClientOrderIdAsync interface and impl should take a string for clientOrderId (the first argument)

To Reproduce
See here:

Task<WebCallResult<FTXOrder>> ModifyOrderByClientOrderIdAsync(long clientOrderId, decimal? price = null, decimal? quantity = null, string? newClientOrderId = null, string? subaccountName = null, CancellationToken ct = default);

clientOrderId is declared as a long

Expected behavior
clientOrderId is a string in the cancel and place methods, so it should probably be a string here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions