Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Airdrops API status field invalid conversion  #20

@OlegOLK

Description

@OlegOLK

When using FTXClient.GetAirdropsAsync method according to the official FTX documentation you get in the return response object that contains status property (https://docs.ftx.com/#get-airdrops). Unfortunately on the left side of the documentation, there are two possible values:
one of "confirmed" or "pending"
But the thing is on the right side you can clearly see that the status value is "complete".
This invalid mapping results in the "pending" status for every single airdrop entity even if it has the status "complete".

To reproduce you need to have an account with some airdrops on it and then

var client = new FTXClient(new FTXClientOptions(){
HttpClient = _client,
ApiCredentials = new ApiCredentials(wallet.ApiKey, wallet.ApiSecret),
LogLevel = LogLevel.Debug,
LogWriters = new List<ILogger> { _logger } });
var airdrops = await client.GetAirdropsAsync(startTime: chunk.from, endTime: chunk.to).ConfigureAwait(false);
airdrops.Data.All(x=> x.Status == AirdropStatus.Pending).Should().BeTrue();

Expected to have

airdrops.Data.All(x=> x.Status == AirdropStatus.Pending).Should().BeFalse(); // and be "complete"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions