Skip to content

Commit 18e0b93

Browse files
committed
optional parameters should be the last parameter
1 parent 1623626 commit 18e0b93

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/Diff.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public function getGroupedOpcodes()
175175
}
176176

177177
require_once dirname(__FILE__).'/Diff/SequenceMatcher.php';
178-
$sequenceMatcher = new Diff_SequenceMatcher($this->a, $this->b, null, $this->options);
178+
$sequenceMatcher = new Diff_SequenceMatcher($this->a, $this->b, $this->options, null);
179179
$this->groupedCodes = $sequenceMatcher->getGroupedOpcodes($this->options['context']);
180180
return $this->groupedCodes;
181181
}

lib/Diff/Renderer/Html/Array.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class Diff_Renderer_Html_Array extends Diff_Renderer_Abstract
6262
* @param mixed $replacement The replacement string.
6363
* @param mixed $start If start is positive, the replacing will begin at the start'th offset into string. If start is negative, the replacing will begin at the start'th character from the end of string.
6464
* @param mixed $length If given and is positive, it represents the length of the portion of string which is to be replaced. If it is negative, it represents the number of characters from the end of string at which to stop replacing. If it is not given, then it will default to strlen( string ); i.e. end the replacing at the end of string. Of course, if length is zero then this function will have the effect of inserting replacement into string at the given start offset.
65-
* @return string The result string is returned. If string is an array then array is returned.
65+
* @return string|array The result string is returned. If string is an array then array is returned.
6666
*/
6767
public function mb_substr_replace($string, $replacement, $start, $length=NULL) {
6868
if (is_array($string)) {

lib/Diff/SequenceMatcher.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ class Diff_SequenceMatcher
103103
*
104104
* @param string|array $a A string or array containing the lines to compare against.
105105
* @param string|array $b A string or array containing the lines to compare.
106-
* @param string|array $junkCallback Either an array or string that references a callback function (if there is one) to determine 'junk' characters.
107106
* @param array $options
107+
* @param string|array $junkCallback Either an array or string that references a callback function (if there is one) to determine 'junk' characters.
108108
*/
109-
public function __construct($a, $b, $junkCallback=null, $options)
109+
public function __construct($a, $b, $options, $junkCallback=null)
110110
{
111111
$this->a = null;
112112
$this->b = null;

0 commit comments

Comments
 (0)