Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryLevelData K field in ServerLevelMixin can be null (crash) #1559

Open
5 tasks done
MehVahdJukaar opened this issue Nov 16, 2024 · 1 comment
Open
5 tasks done
Labels
Status: Waiting for Fix | 等待处理 Problem confirmed, waiting for fix Tag: Bug | 工作不正常 Something isn't working, but not crash Version: Trials (1.20/1.20.1)

Comments

@MehVahdJukaar
Copy link

I have confirmed that ...

  • Arclight is up to date
  • all dependencies are installed
  • all plugins and mods are up to date
  • unable to reproduce in Spigot
  • unable to reproduce in Forge

Arclight version

1.20.1-1.0.6-SNAPSHOT

OS & Java versions

21

Plugins and Mods

no plugins

Description

In ServerLevelMixin you have 2 instance of check which assing a value to that PrimaryLevelData K field.
Obviously this allows for a branch in whih neither are true (which can and will happen with mods as that class is NOT sealed and mods are free to subclass it), causing a crash in the code that's right after that since you arent null checking it

Step to reproduce

No response

Logs

No response

Server pack link (Optional)

No response

@MehVahdJukaar MehVahdJukaar added the Status: Triage | 待检查 Default label, waiting for triage label Nov 16, 2024
@Igneaalis
Copy link

Igneaalis commented Nov 16, 2024

causes #1557

@qyl27 qyl27 added Tag: Bug | 工作不正常 Something isn't working, but not crash Version: Trials (1.20/1.20.1) Status: Waiting for Fix | 等待处理 Problem confirmed, waiting for fix and removed Status: Triage | 待检查 Default label, waiting for triage labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for Fix | 等待处理 Problem confirmed, waiting for fix Tag: Bug | 工作不正常 Something isn't working, but not crash Version: Trials (1.20/1.20.1)
Projects
None yet
Development

No branches or pull requests

3 participants