Skip to content

Commit baa6b87

Browse files
authored
Merge pull request #925 from Iterable/MOB-11526-SampleApp-Maintenance
[MOB-11526] - Gradle upgrade for sample apps
2 parents 59493b2 + 7a59f8d commit baa6b87

File tree

7 files changed

+41
-26
lines changed

7 files changed

+41
-26
lines changed

sample-apps/inbox-customization/app/build.gradle

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@ apply plugin: 'com.android.application'
22

33
apply plugin: 'kotlin-android'
44

5-
apply plugin: 'kotlin-android-extensions'
6-
75
android {
8-
compileSdkVersion 34
6+
namespace "com.iterable.inbox_customization"
7+
compileSdk 34
98
buildToolsVersion "33.0.2"
109
defaultConfig {
1110
applicationId "com.iterable.inbox_customization"
@@ -21,23 +20,33 @@ android {
2120
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
2221
}
2322
}
23+
compileOptions {
24+
sourceCompatibility JavaVersion.VERSION_1_8
25+
targetCompatibility JavaVersion.VERSION_1_8
26+
}
27+
kotlinOptions {
28+
jvmTarget = '1.8'
29+
}
30+
buildFeatures {
31+
viewBinding true
32+
}
2433
}
2534

2635
dependencies {
2736
implementation fileTree(dir: 'libs', include: ['*.jar'])
2837
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
29-
implementation 'androidx.appcompat:appcompat:1.0.2'
30-
implementation 'androidx.core:core-ktx:1.0.2'
31-
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
32-
implementation 'androidx.navigation:navigation-fragment-ktx:2.1.0'
33-
implementation 'androidx.navigation:navigation-ui-ktx:2.1.0'
34-
implementation 'com.google.android.material:material:1.1.0'
38+
implementation 'androidx.appcompat:appcompat:1.6.1'
39+
implementation 'androidx.core:core-ktx:1.10.1'
40+
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
41+
implementation 'androidx.navigation:navigation-fragment-ktx:2.6.0'
42+
implementation 'androidx.navigation:navigation-ui-ktx:2.6.0'
43+
implementation 'com.google.android.material:material:1.9.0'
3544

3645
implementation 'com.iterable:iterableapi:3.5.14'
3746
implementation 'com.iterable:iterableapi-ui:3.5.14'
3847
implementation 'com.squareup.okhttp3:mockwebserver:4.2.2'
3948

40-
testImplementation 'junit:junit:4.12'
41-
androidTestImplementation 'androidx.test.ext:junit:1.1.0'
42-
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
49+
testImplementation 'junit:junit:4.13.2'
50+
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
51+
androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
4352
}

sample-apps/inbox-customization/app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.iterable.inbox_customization">
2+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
3+
4+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
45

56
<application
67
android:name=".SampleApplication"

sample-apps/inbox-customization/app/src/main/java/com/iterable/inbox_customization/MainActivity.kt

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,23 @@ import androidx.navigation.ui.setupActionBarWithNavController
77
import androidx.navigation.ui.setupWithNavController
88
import com.iterable.iterableapi.IterableApi
99
import com.iterable.iterableapi.IterableInAppManager
10-
import kotlinx.android.synthetic.main.activity_main.*
10+
import com.iterable.inbox_customization.databinding.ActivityMainBinding
1111

1212
class MainActivity : AppCompatActivity(), IterableInAppManager.Listener {
1313

14+
private lateinit var binding: ActivityMainBinding
15+
1416
override fun onCreate(savedInstanceState: Bundle?) {
1517
super.onCreate(savedInstanceState)
16-
setContentView(R.layout.activity_main)
18+
binding = ActivityMainBinding.inflate(layoutInflater)
19+
setContentView(binding.root)
1720
setupNavigation()
1821
}
1922

2023
private fun setupNavigation() {
2124
val navController = Navigation.findNavController(this, R.id.mainNavigationFragment)
2225
setupActionBarWithNavController(navController)
23-
bottomNavigationView.setupWithNavController(navController)
26+
binding.bottomNavigationView.setupWithNavController(navController)
2427
}
2528

2629
override fun onResume() {
@@ -40,8 +43,8 @@ class MainActivity : AppCompatActivity(), IterableInAppManager.Listener {
4043
}
4144

4245
private fun updateNotificationBadge(value: Int) {
43-
val simpleInboxBadge = bottomNavigationView.getOrCreateBadge(R.id.simpleInboxFragment)
44-
val customInboxBadge = bottomNavigationView.getOrCreateBadge(R.id.customInboxFragment)
46+
val simpleInboxBadge = binding.bottomNavigationView.getOrCreateBadge(R.id.simpleInboxFragment)
47+
val customInboxBadge = binding.bottomNavigationView.getOrCreateBadge(R.id.customInboxFragment)
4548
simpleInboxBadge.number = value
4649
customInboxBadge.number = value
4750
}

sample-apps/inbox-customization/app/src/main/res/layout/dark_inbox_cell.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
android:layout_marginLeft="8dp"
1919
android:layout_marginTop="8dp"
2020
android:src="@drawable/unread_indicator"
21-
android:tint="#F71113"
21+
app:tint="#F71113"
2222
android:layout_alignParentStart="true"
2323
android:layout_marginStart="8dp" />
2424

sample-apps/inbox-customization/build.gradle

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
// Top-level build file where you can add configuration options common to all sub-projects/modules.
22

33
buildscript {
4-
ext.kotlin_version = '1.3.61'
4+
ext.kotlin_version = '1.8.0'
55
repositories {
66
google()
7-
jcenter()
8-
7+
mavenCentral()
98
}
109
dependencies {
11-
classpath 'com.android.tools.build:gradle:3.5.10'
10+
classpath 'com.android.tools.build:gradle:8.2.2'
1211
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
1312
// NOTE: Do not place your application dependencies here; they belong
1413
// in the individual module build.gradle files
@@ -18,7 +17,7 @@ buildscript {
1817
allprojects {
1918
repositories {
2019
google()
21-
jcenter()
20+
mavenCentral()
2221
}
2322
}
2423

sample-apps/inbox-customization/gradle.properties

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,6 @@ android.useAndroidX=true
1919
android.enableJetifier=true
2020
# Kotlin code style for this project: "official" or "obsolete":
2121
kotlin.code.style=official
22+
android.nonTransitiveRClass=false
23+
android.defaults.buildfeatures.buildconfig=true
24+
android.nonFinalResIds=false
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#Fri Feb 21 17:13:45 PST 2020
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
4+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-all.zip
45
zipStoreBase=GRADLE_USER_HOME
56
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

0 commit comments

Comments
 (0)