Skip to content

Commit b0e3f88

Browse files
committed
Made recommended changes
1 parent bd0594f commit b0e3f88

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ public void execute(@Nullable String data) {
326326
}
327327
try {
328328
JSONObject jsonData = new JSONObject(data);
329-
boolean offlineConfiguration = jsonData.getBoolean(IterableConstants.SHARED_PREFS_OFFLINE_MODE_KEY);
329+
boolean offlineConfiguration = jsonData.getBoolean(IterableConstants.KEY_OFFLINE_MODE);
330330
sharedInstance.apiClient.setOfflineProcessingEnabled(offlineConfiguration);
331331
SharedPreferences sharedPref = sharedInstance.getMainActivityContext().getSharedPreferences(IterableConstants.SHARED_PREFS_SAVED_CONFIGURATION, Context.MODE_PRIVATE);
332332
SharedPreferences.Editor editor = sharedPref.edit();

iterableapi/src/main/java/com/iterable/iterableapi/IterableConstants.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public final class IterableConstants {
5353
public static final String KEY_USER = "user";
5454
public static final String KEY_USER_TEXT = "userText";
5555
public static final String KEY_INBOX_SESSION_ID = "inboxSessionId";
56+
public static final String KEY_OFFLINE_MODE = "offlineMode";
5657

5758
//API Endpoint Key Constants
5859
public static final String ENDPOINT_DISABLE_DEVICE = "users/disableDevice";
@@ -110,7 +111,7 @@ public final class IterableConstants {
110111
public static final int SHARED_PREFS_ATTRIBUTION_INFO_EXPIRATION_HOURS = 24;
111112
public static final String SHARED_PREFS_FCM_MIGRATION_DONE_KEY = "itbl_fcm_migration_done";
112113
public static final String SHARED_PREFS_SAVED_CONFIGURATION = "itbl_saved_configuration";
113-
public static final String SHARED_PREFS_OFFLINE_MODE_KEY = "SDKOfflineMode";
114+
public static final String SHARED_PREFS_OFFLINE_MODE_KEY = "itbl_offline_mode";
114115

115116
//Action buttons
116117
public static final String ITBL_BUTTON_IDENTIFIER = "identifier";

iterableapi/src/test/java/com/iterable/iterableapi/IterableApiTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ public void testFetchRemoteConfigurationCalledWhenInForeground() throws Exceptio
675675

676676
server.enqueue(new MockResponse().setResponseCode(200).setBody("{\n" +
677677
" \"offlineMode\": false,\n" +
678-
" \"" + IterableConstants.SHARED_PREFS_OFFLINE_MODE_KEY + "\": true,\n" +
678+
" \"" + IterableConstants.KEY_OFFLINE_MODE + "\": true,\n" +
679679
" \"someOtherKey1\": \"someOtherValue1\"\n" +
680680
" }"));
681681
IterableActivityMonitor.getInstance().unregisterLifecycleCallbacks(getContext());

0 commit comments

Comments
 (0)