Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when trying to click the "File path" URL that is given when looking at song info #410

Open
ctracy opened this issue May 14, 2023 · 0 comments

Comments

@ctracy
Copy link

ctracy commented May 14, 2023

In webapp/alpha/m.js, function openMetadataModal(), there is a section which prepares the URL to be displayed as the "File path" here:

Screenshot 2023-05-14 at 3 25 42 PM

In my instance, I have found that there is a missing forward slash near line 559. I had to modify the code like this in order to be able to click on album art when displaying the song info in order to not get an error. See my diff below:

diff --git a/webapp/alpha/m.js b/webapp/alpha/m.js
index e5005de..686d92e 100644
--- a/webapp/alpha/m.js
+++ b/webapp/alpha/m.js
@@ -556,7 +556,10 @@ function openMetadataModal(metadata, fp) {
   document.getElementById('meta--rating').innerHTML = metadata.rating;
   document.getElementById('meta--rg').innerHTML = metadata['replaygain-track'];
   document.getElementById('meta--fp').innerHTML = fp;
-  document.getElementById('meta--fp').href = 'media' + fp;
+  // this should really be 'media/' otherwise you get an error when trying to click the URL
+  // this is displayed when you click the album art when playing a song or go to the song info
+  document.getElementById('meta--fp').href = 'media/' + fp;
   document.getElementById('meta--aa').innerHTML = 'album-art/' + metadata['album-art'];
   if (metadata['album-art']) {
     document.getElementById('meta--aa').href = `album-art/${metadata['album-art']}`;
@ctracy ctracy changed the title error when trying to click the URL that is given for displaying album art, e.g. when looking at song info error when trying to click the "File path" URL that is given when looking at song info May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant