You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How to reproduce:
call extract_from_url with http://127.0.0.1 as input.
result will be {subdomain: 127.0.0, domain: 1}
expected behavior: throw Invalid Domain Error
The text was updated successfully, but these errors were encountered:
Technically this is a valid domain. I'm not sure what to do here. Validating the domain here is weird.
Ensuring the domain is not an IP gonna be hard here. I think we should tolerate such cases.
Technically this is a valid domain. I'm not sure what to do here. Validating the domain here is weird. Ensuring the domain is not an IP gonna be hard here. I think we should tolerate such cases.
From IETF RFC3696, top-level domain names cannot be all numeric (i.e. In the case of http://127.0.0.1, 1 is not a TLD, hence 127.0.0.1 cannot be a fully-qualified domain name (FQDN))
How to reproduce:
call
extract_from_url
with http://127.0.0.1 as input.result will be
{subdomain: 127.0.0, domain: 1}
expected behavior: throw Invalid Domain Error
The text was updated successfully, but these errors were encountered: