Skip to content

Commit ff1f623

Browse files
committed
Apply suggestions
1 parent b19c292 commit ff1f623

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

bench/cardano-profile/src/Cardano/Benchmarking/Profile/Primitives.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ empty = Types.Profile {
157157
, Types.shelley = mempty
158158
, Types.alonzo = mempty
159159
, Types.conway = Nothing
160+
, Types.dijkstra = Nothing
160161
, Types.slot_duration = 0
161162
, Types.epoch_length = 0
162163
, Types.active_slots_coeff = 0

bench/cardano-profile/src/Cardano/Benchmarking/Profile/Types.hs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ instance Aeson.FromJSON Era where
273273
-- | Minimal major protocol version per era
274274
firstEraForMajorVersion :: Int -> Era
275275
firstEraForMajorVersion pv
276-
| pv >= _ = Dijkstra -- TODO: (@russoul)
276+
| pv >= 11 = Dijkstra -- TODO: Once Dijkstra era is out, re-check the value
277277
| pv >= 9 = Conway
278278
| pv >= 7 = Babbage
279279
| pv >= 5 = Alonzo
@@ -299,7 +299,6 @@ cf. https://github.com/cardano-foundation/CIPs/blob/master/CIP-0059/feature-tabl
299299
| 2024/09 | Voltaire | Conway | 133660855 | 507 | 9,0 | Praos | Ouroboros Genesis/Praos | Chang HF |
300300
| 2025/01 | Voltaire | Conway | 146620809 | 537 | 10,0 | Praos | Ouroboros Genesis/Praos | Plomin HF |
301301
-}
302-
-- TODO: Update the table (@russoul)
303302

304303
--------------------------------------------------------------------------------
305304

@@ -315,7 +314,7 @@ data Genesis = Genesis
315314
, shelley :: KM.KeyMap Aeson.Value
316315
, alonzo :: KM.KeyMap Aeson.Value
317316
, conway :: Maybe (KM.KeyMap Aeson.Value) -- TODO: Remove the null.
318-
-- TODO: Should anything be added for Dijkstra (@russoul)?
317+
, dijkstra :: Maybe (KM.KeyMap Aeson.Value)
319318

320319
-- Absolute durations:
321320
, slot_duration :: Time.NominalDiffTime

0 commit comments

Comments
 (0)