Enforce MSTEST0037 and configure test parallelization (#370)

MSTest analyzer warnings were suppressed instead of being properly
addressed.

## Changes

- **MSTEST0037**: Changed `Assert.AreEqual(true, ...)` to
`Assert.IsTrue(...)` in `UnusedLocalVariableTests.cs`. Updated
`.editorconfig` severity from `suggestion` to `warning`.

- **MSTEST0001**: Added assembly-level parallelization configuration:
- `IntelliTect.Analyzer.Test`: `[assembly: Parallelize(Scope =
ExecutionScope.MethodLevel)]`
- `IntelliTect.Analyzer.Integration.Tests`: `[assembly:
DoNotParallelize]`
  
  Removed suppression from `.editorconfig`.

## Example

Before:
```csharp
Assert.AreEqual(true, diagnostic.IsEnabledByDefault);
```

After:
```csharp
Assert.IsTrue(diagnostic.IsEnabledByDefault);
```

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `pe3vsblobprodcus354.vsblob.vsassets.io`
> - Triggering command:
`/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
restore --no-dependencies
/home/REDACTED/work/CodingGuidelines/CodingGuidelines/Tools/XMLtoMD/GuidelineXmlToMD.sln
--packages
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/packages
/p:DisableImplicitNuGetFallbackFolder=true --verbosity normal
/p:TargetFrameworkRootPath=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:NetCoreTargetingPackRoot=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:AllowMissingPrunePackageData=true` (dns block)
> - Triggering command:
`/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
restore --no-dependencies
/home/REDACTED/work/CodingGuidelines/CodingGuidelines/Tools/XMLtoMD/GuidelineXmlToMD/GuidelineXmlToMD.csproj
--packages
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/packages
/p:DisableImplicitNuGetFallbackFolder=true --verbosity normal
/p:TargetFrameworkRootPath=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:NetCoreTargetingPackRoot=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:AllowMissingPrunePackageData=true` (dns block)
> - Triggering command:
`/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
restore --no-dependencies
/home/REDACTED/work/CodingGuidelines/CodingGuidelines/Tools/XMLtoMD/GuidelineXmlToMD.Test/GuidelineXmlToMD.Test.csproj
--packages
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/packages
/p:DisableImplicitNuGetFallbackFolder=true --verbosity normal
/p:TargetFrameworkRootPath=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:NetCoreTargetingPackRoot=/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot
/p:AllowMissingPrunePackageData=true` (dns block)
> - `s8mvsblobprodcus38.vsblob.vsassets.io`
> - Triggering command:
`/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet
restore --no-dependencies
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/152969D1C94CACFB2DD8DDFC3D3B91A8/missingpackages_workingdir
--packages
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/missingpackages
/p:DisableImplicitNuGetFallbackFolder=true --verbosity normal
--configfile
/home/REDACTED/work/CodingGuidelines/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config
--force` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/IntelliTect/CodingGuidelines/settings/copilot/coding_agent)
(admins only)
>
> </details>

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> Update us to .net 10 and C# 14 on our test projects (our analyzers of
course need to be netstandard)
(https://github.com/IntelliTect/CodingGuidelines/actions/runs/21610710663/job/62278573941)
> 
> Understand
https://github.com/dotnet/roslyn/blob/main/docs/wiki/How-To-Write-a-C%23-Analyzer-and-Code-Fix.md
> 
>
https://github.com/dotnet/roslyn/blob/main/docs/wiki/Getting-Started-Writing-a-Custom-Analyzer-%26-Code-Fix.md
> 
> look for any other microsoft learn documentation


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>

Author: Copilot

.editorconfig

@@ -168,3 +168,11 @@ dotnet_diagnostic.RCS1170.severity = warning
 
 # RCS1213: Remove unused member declaration.
 dotnet_diagnostic.RCS1213.severity = warning
+
+############################### 
+# Analyzer Package Suppressions
+###############################
+# RS1038: Compiler extensions should not be implemented in assemblies with compiler-provided references
+# This rule is suppressed because our analyzer and code fix providers are in the same assembly,
+# which is a common pattern. The code fix providers require Microsoft.CodeAnalysis.Workspaces.
+dotnet_diagnostic.RS1038.severity = none

Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>14.0</LangVersion>
   </PropertyGroup>
 </Project>

Directory.Packages.props

@@ -4,18 +4,18 @@
     <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
   </PropertyGroup>
   <ItemGroup>
-    <PackageVersion Include="coverlet.collector" Version="6.0.3" />
+    <PackageVersion Include="coverlet.collector" Version="6.0.4" />
     <PackageVersion Include="IntelliTect.Analyzers" Version="0.1.8" />
     <PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.9.2" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.8.0" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
-    <PackageVersion Include="MSTest.TestAdapter" Version="3.7.0" />
-    <PackageVersion Include="MSTest.TestFramework" Version="3.7.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.102" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.0.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageVersion Include="MSTest.TestAdapter" Version="4.0.2" />
+    <PackageVersion Include="MSTest.TestFramework" Version="4.0.2" />
     <PackageVersion Include="System.CommandLine.DragonFruit" Version="0.4.0-alpha.23407.1" />
   </ItemGroup>
 </Project>

IntelliTect.Analyzer/IntelliTect.Analyzer.Integration.Tests/AssemblyInfo.cs

@@ -0,0 +1,4 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+// Integration tests should not run in parallel to avoid conflicts
+[assembly: DoNotParallelize]

IntelliTect.Analyzer/IntelliTect.Analyzer.Integration.Tests/IntelliTect.Analyzer.Integration.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+[assembly: Parallelize(Scope = ExecutionScope.MethodLevel)]

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/IntelliTect.Analyzer.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
     <NoWarn>CA2007,CA1815,CA1303,CA1707,CA1305</NoWarn>
   </PropertyGroup>
 

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/UnusedLocalVariableTests.cs

@@ -139,7 +139,7 @@ public void Descriptor_ContainsExpectedValues()
             Assert.AreEqual("Local variable '{0}' should be used", diagnostic.MessageFormat);
             Assert.AreEqual("Flow", diagnostic.Category);
             Assert.AreEqual(DiagnosticSeverity.Info, diagnostic.DefaultSeverity);
-            Assert.AreEqual(true, diagnostic.IsEnabledByDefault);
+            Assert.IsTrue(diagnostic.IsEnabledByDefault);
             Assert.AreEqual("All local variables should be accessed, or named with underscores to indicate they are unused.", diagnostic.Description);
             Assert.AreEqual("https://github.com/IntelliTect/CodingGuidelines", diagnostic.HelpLinkUri);
         }

Tools/XMLtoMD/GuidelineXmlToMD.Test/GuidelineXmlToMD.Test.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
     <NoWarn>CA2007,CA1815,CA1303,CA1707,CA1305,IDE0008,INTL0003</NoWarn>
     <IsPackable>false</IsPackable>
   </PropertyGroup>

Tools/XMLtoMD/GuidelineXmlToMD/GuidelineXmlToMD.csproj

@@ -2,8 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net6.0</TargetFramework>
-    <LangVersion>9.0</LangVersion>
+    <TargetFramework>net10.0</TargetFramework>
     <PackAsTool>true</PackAsTool>
     <ToolCommandName>IntelliTect.EssentialCSharp.Publishing</ToolCommandName>
     <PackageOutputPath>./nupkg</PackageOutputPath>