Skip to content

Commit f23dadc

Browse files
DavidMina96HeshamMegid
authored andcommitted
[MOB-10648] Add Overridable String Keys (#840)
1 parent 1352d8c commit f23dadc

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
- Bumps Instabug Android SDK to v11.7.0
44
- Bumps Instabug iOS SDK to v11.6.0
5+
- Adds new string keys: insufficientContentMessage and insufficientContentTitle
6+
- Adds missing mapping for some existing keys if relevant to the other platform
7+
- Removes the string key: video
58

69
## 11.5.1 (2022-12-14)
710

android/src/main/java/com/instabug/reactlibrary/ArgsRegistry.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ static Map<String, Object> getAll() {
201201
put("recordingMessageToHoldText", Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
202202
put("recordingMessageToReleaseText", Key.VOICE_MESSAGE_RELEASE_TO_ATTACH);
203203
put("thankYouText", Key.SUCCESS_DIALOG_HEADER);
204-
put("video", Key.VIDEO_PLAYER_TITLE);
205204
put("videoPressRecord", Key.VIDEO_RECORDING_FAB_BUBBLE_HINT);
206205
put("conversationTextFieldHint", Key.CONVERSATION_TEXT_FIELD_HINT);
207206
put("thankYouAlertText", Key.REPORT_SUCCESSFULLY_SENT);
@@ -236,5 +235,12 @@ static Map<String, Object> getAll() {
236235
put("reproStepsListDescription", Key.REPRO_STEPS_LIST_DESCRIPTION);
237236
put("reproStepsListEmptyStateDescription", Key.REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION);
238237
put("reproStepsListItemTitle", Key.REPRO_STEPS_LIST_ITEM_NUMBERING_TITLE);
238+
put("okButtonTitle", Key.BUG_ATTACHMENT_DIALOG_OK_BUTTON);
239+
put("audio", Key.CHATS_TYPE_AUDIO);
240+
put("image", Key.CHATS_TYPE_IMAGE);
241+
put("screenRecording", Key.CHATS_TYPE_VIDEO);
242+
put("messagesNotificationAndOthers", Key.CHATS_MULTIPLE_MESSAGE_NOTIFICATION);
243+
put("team", Key.CHATS_TEAM_STRING_NAME);
244+
put("insufficientContentMessage", Key.COMMENT_FIELD_INSUFFICIENT_CONTENT);
239245
}};
240246
}

ios/RNInstabug/ArgsRegistry.m

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,10 @@ + (ArgsDictionary *) locales {
252252
@"reproStepsListHeader": kIBGReproStepsListTitle,
253253
@"reproStepsListDescription": kIBGReproStepsListHeader,
254254
@"reproStepsListEmptyStateDescription": kIBGReproStepsListEmptyStateLabel,
255-
@"reproStepsListItemTitle": kIBGReproStepsListItemName
255+
@"reproStepsListItemTitle": kIBGReproStepsListItemName,
256+
@"conversationTextFieldHint": kIBGChatReplyFieldPlaceholderStringName,
257+
@"insufficientContentTitle" : kIBGInsufficientContentTitleStringName,
258+
@"insufficientContentMessage" : kIBGInsufficientContentMessageStringName,
256259
};
257260
}
258261

src/utils/ArgsRegistry.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ export enum strings {
197197
cancelButtonText = NativeInstabug.cancelButtonTitle,
198198
thankYouText = NativeInstabug.thankYouText,
199199
audio = NativeInstabug.audio,
200-
video = NativeInstabug.video,
201200
image = NativeInstabug.image,
202201
team = NativeInstabug.team,
203202
messagesNotification = NativeInstabug.messagesNotification,
@@ -231,4 +230,7 @@ export enum strings {
231230
reproStepsListDescription = NativeInstabug.reproStepsListDescription,
232231
reproStepsListEmptyStateDescription = NativeInstabug.reproStepsListEmptyStateDescription,
233232
reproStepsListItemTitle = NativeInstabug.reproStepsListItemTitle,
233+
screenRecording = NativeInstabug.screenRecording,
234+
insufficientContentMessage = NativeInstabug.insufficientContentMessage,
235+
insufficientContentTitle = NativeInstabug.insufficientContentTitle,
234236
}

0 commit comments

Comments
 (0)