Skip to content

Commit eb1ecff

Browse files
a7medevHeshamMegid
authored andcommitted
chore: deprecate old bug content string keys (#1026)
Jira ID: MOB-13020
1 parent e352bee commit eb1ecff

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
- Deprecate the old `StringKey.discardAlertCancel` and `StringKey.discardAlertAction` string keys for overriding the discard alert buttons as they had incosistent behavior between iOS and Android ([#1001](https://github.com/Instabug/Instabug-React-Native/pull/1001)).
2222
- Deprecate the old `StringKey.reproStepsListItemNumberingTitle` string key for overriding the repro steps list item (screen) title as it had incosistent behavior between iOS and Android ([#1002](https://github.com/Instabug/Instabug-React-Native/pull/1002)).
2323
- Deprecate `Instabug.setReproStepsMode` in favor of the new `Instabug.setReproStepsConfig` ([#1024](https://github.com/Instabug/Instabug-React-Native/pull/1024)).
24+
- Deprecate the old `StringKey.invalidCommentMessage` and `StringKey.invalidCommentTitle` in favor of `StringKey.insufficientContentMessage` and `StringKey.insufficientContentTitle` ([#1026](https://github.com/Instabug/Instabug-React-Native/pull/1026)).
2425

2526
## [11.13.0](https://github.com/Instabug/Instabug-React-Native/compare/v11.12.0...v11.13.0) (July 10, 2023)
2627

android/src/main/java/com/instabug/reactlibrary/ArgsRegistry.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ static Map<String, Object> getAll() {
201201
put("shakeHint", Key.SHAKE_HINT);
202202
put("swipeHint", Key.SWIPE_HINT);
203203
put("invalidEmailMessage", Key.INVALID_EMAIL_MESSAGE);
204+
// Deprecated
204205
put("invalidCommentMessage", Key.INVALID_COMMENT_MESSAGE);
205206
put("emailFieldHint", Key.EMAIL_FIELD_HINT);
206207
put("commentFieldHintForBugReport", Key.COMMENT_FIELD_HINT_FOR_BUG_REPORT);

ios/RNInstabug/ArgsRegistry.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,12 @@ + (ArgsDictionary *) locales {
187187
@"startAlertText": kIBGStartAlertTextStringName,
188188
@"invalidEmailMessage": kIBGInvalidEmailMessageStringName,
189189
@"invalidEmailTitle": kIBGInvalidEmailTitleStringName,
190+
191+
// Deprecated
190192
@"invalidCommentMessage": kIBGInvalidCommentMessageStringName,
193+
// Deprecated
191194
@"invalidCommentTitle": kIBGInvalidCommentTitleStringName,
195+
192196
@"invocationHeader": kIBGInvocationTitleStringName,
193197
@"reportQuestion": kIBGAskAQuestionStringName,
194198
@"reportBug": kIBGReportBugStringName,

src/utils/Enums.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,15 @@ export enum StringKey {
171171
edgeSwipeStartHint = constants.edgeSwipeStartHint,
172172
emailFieldHint = constants.emailFieldHint,
173173
image = constants.image,
174+
174175
insufficientContentMessage = constants.insufficientContentMessage,
176+
/** iOS only */
175177
insufficientContentTitle = constants.insufficientContentTitle,
178+
/** @deprecated Use {@link insufficientContentMessage} instead. */
176179
invalidCommentMessage = constants.invalidCommentMessage,
180+
/** @deprecated Use {@link insufficientContentTitle} instead. */
177181
invalidCommentTitle = constants.invalidCommentTitle,
182+
178183
invalidEmailMessage = constants.invalidEmailMessage,
179184
invalidEmailTitle = constants.invalidEmailTitle,
180185
invocationHeader = constants.invocationHeader,

0 commit comments

Comments
 (0)