Rename native method

Author: TheBuggedYRN

android/src/main/java/com/instabug/reactlibrary/RNInstabugBugReportingModule.java

@@ -283,7 +283,7 @@ public void run() {
      *                              dismissing the SDK.
      */
     @ReactMethod
-    public void setOnSDKDismissedHandler(final Callback handler) {
+    public void setOnDismissHandler(final Callback handler) {
         MainThreadHandler.runOnMainThread(new Runnable() {
             @Override
             public void run() {

android/src/test/java/com/instabug/reactlibrary/RNInstabugBugReportingModuleTest.java

@@ -246,7 +246,7 @@ public Object answer(InvocationOnMock invocation) {
 
 
     @Test
-    public void given$setOnSDKDismissedHandler_whenQuery_thenShouldSetNativeCallback() {
+    public void given$setOnDismissHandler_whenQuery_thenShouldSetNativeCallback() {
         // given
         MockedStatic mockArgument = mockStatic(Arguments.class);
         MockedStatic mockReactApplicationContext = mockStatic(ReactApplicationContext.class);
@@ -259,7 +259,7 @@ public Object answer(InvocationOnMock invocation) {
                         .call(OnSdkDismissCallback.DismissType.CANCEL, OnSdkDismissCallback.ReportType.BUG);
                 return null;
             }});
-        bugReportingModule.setOnSDKDismissedHandler(null);
+        bugReportingModule.setOnDismissHandler(null);
 
         // then
         WritableMap params = new JavaOnlyMap();

example/ios/InstabugTests/InstabugBugReportingTests.m

@@ -70,10 +70,10 @@ - (void) testgivenHandler$setOnInvokeHandler_whenQuery_thenShouldCallNativeApi {
 }
 
 
-- (void) testgivenHandlerCANCEL$setOnSDKDismissedHandler_whenQuery_thenShouldCallNativeApi {
+- (void) testgivenHandlerCANCEL$setOnDismissHandler_whenQuery_thenShouldCallNativeApi {
   id partialMock = OCMPartialMock(self.instabugBridge);
   RCTResponseSenderBlock callback = ^(NSArray *response) {};
-  [partialMock setOnSDKDismissedHandler:callback];
+  [partialMock setOnDismissHandler:callback];
   XCTAssertNotNil(IBGBugReporting.didDismissHandler);
   NSDictionary *result = @{ @"dismissType": @"CANCEL",
                             @"reportType": @"bug"};
@@ -82,10 +82,10 @@ - (void) testgivenHandlerCANCEL$setOnSDKDismissedHandler_whenQuery_thenShouldCal
   OCMVerify([partialMock sendEventWithName:@"IBGpostInvocationHandler" body:result]);
 }
 
-- (void) testgivenHandlerSUBMIT$setOnSDKDismissedHandler_whenQuery_thenShouldCallNativeApi {
+- (void) testgivenHandlerSUBMIT$setOnDismissHandler_whenQuery_thenShouldCallNativeApi {
   id partialMock = OCMPartialMock(self.instabugBridge);
   RCTResponseSenderBlock callback = ^(NSArray *response) {};
-  [partialMock setOnSDKDismissedHandler:callback];
+  [partialMock setOnDismissHandler:callback];
   XCTAssertNotNil(IBGBugReporting.didDismissHandler);
 
   NSDictionary *result = @{ @"dismissType": @"SUBMIT",
@@ -95,10 +95,10 @@ - (void) testgivenHandlerSUBMIT$setOnSDKDismissedHandler_whenQuery_thenShouldCal
   OCMVerify([partialMock sendEventWithName:@"IBGpostInvocationHandler" body:result]);
 }
 
-- (void) testgivenHandlerADD_ATTACHMENT$setOnSDKDismissedHandler_whenQuery_thenShouldCallNativeApi {
+- (void) testgivenHandlerADD_ATTACHMENT$setOnDismissHandler_whenQuery_thenShouldCallNativeApi {
   id partialMock = OCMPartialMock(self.instabugBridge);
   RCTResponseSenderBlock callback = ^(NSArray *response) {};
-  [partialMock setOnSDKDismissedHandler:callback];
+  [partialMock setOnDismissHandler:callback];
   XCTAssertNotNil(IBGBugReporting.didDismissHandler);
   NSDictionary *result = @{ @"dismissType": @"ADD_ATTACHMENT",
                             @"reportType": @"feedback"};

ios/RNInstabug/InstabugBugReportingBridge.h

@@ -29,7 +29,7 @@
 
 - (void)setOnInvokeHandler:(RCTResponseSenderBlock)callBack;
 
-- (void)setOnSDKDismissedHandler:(RCTResponseSenderBlock)callBack;
+- (void)setOnDismissHandler:(RCTResponseSenderBlock)callBack;
 
 - (void)setShakingThresholdForiPhone:(double)iPhoneShakingThreshold;
 

ios/RNInstabug/InstabugBugReportingBridge.m

@@ -57,7 +57,7 @@ + (BOOL)requiresMainQueueSetup
     }
 }
 
-RCT_EXPORT_METHOD(setOnSDKDismissedHandler:(RCTResponseSenderBlock)callBack) {
+RCT_EXPORT_METHOD(setOnDismissHandler:(RCTResponseSenderBlock)callBack) {
     if (callBack != nil) {
         IBGBugReporting.didDismissHandler = ^(IBGDismissType dismissType, IBGReportType reportType) {
             // Unlinke Android, we do NOT need to map the iOS Enums to their JS constant names.

src/modules/BugReporting.ts

@@ -106,7 +106,7 @@ export const onDismissHandler = (
     },
   );
 
-  NativeBugReporting.setOnSDKDismissedHandler(handler);
+  NativeBugReporting.setOnDismissHandler(handler);
 };
 
 /**

src/native/NativeBugReporting.ts

@@ -54,7 +54,7 @@ export interface BugReportingNativeModule extends NativeModule {
   // Callbacks //
   setOnInvokeHandler(handler: () => void): void;
   setDidSelectPromptOptionHandler(handler: (promptOption: string) => void): void;
-  setOnSDKDismissedHandler(
+  setOnDismissHandler(
     handler: (dismissType: dismissType | DismissType, reportType: reportType | ReportType) => void,
   ): void;
 }

test/mocks/mockBugReporting.ts

@@ -14,7 +14,7 @@ const mockBugReporting: BugReportingNativeModule = {
   setReportTypes: jest.fn(),
   show: jest.fn(),
   setOnInvokeHandler: jest.fn(),
-  setOnSDKDismissedHandler: jest.fn(),
+  setOnDismissHandler: jest.fn(),
   setAutoScreenRecordingEnabled: jest.fn(),
   setAutoScreenRecordingDuration: jest.fn(),
   setViewHierarchyEnabled: jest.fn(),

test/modules/BugReporting.spec.ts

@@ -142,12 +142,12 @@ describe('Testing BugReporting Module', () => {
     expect(callback).toHaveBeenCalled();
   });
 
-  it('should call the native method setOnSDKDismissedHandler with a function', () => {
+  it('should call the native method setOnDismissHandler with a function', () => {
     const callback = jest.fn();
     BugReporting.onSDKDismissedHandler(callback);
 
-    expect(NativeBugReporting.setOnSDKDismissedHandler).toBeCalledTimes(1);
-    expect(NativeBugReporting.setOnSDKDismissedHandler).toBeCalledWith(callback);
+    expect(NativeBugReporting.setOnDismissHandler).toBeCalledTimes(1);
+    expect(NativeBugReporting.setOnDismissHandler).toBeCalledWith(callback);
   });
 
   it('should invoke callback on emitting the event IBGpostInvocationHandler', () => {