fix: update network body max size handling and caching

- Changed the return type of `getNetworkBodyMaxSize` from `int?` to `double?` in the API and updated related method calls accordingly.
- Renamed `registerW3CFlagsListener` to `registerFeatureFlagsListener` for consistency across the codebase.
- Introduced a callback mechanism in `FeatureFlagsManager` to handle changes in network body max size, ensuring proper cache management in `NetworkManager`.
- Updated tests to reflect the new method names and ensure functionality remains intact.

Author: MoKamall

android/src/main/java/com/instabug/flutter/modules/InstabugApi.java

@@ -516,13 +516,13 @@ public void setNetworkLogBodyEnabled(@NonNull Boolean isEnabled) {
     }
 
     @Override
-    public void getNetworkBodyMaxSize(@NonNull InstabugPigeon.Result<Long> result) {
+    public void getNetworkBodyMaxSize(@NonNull InstabugPigeon.Result<Double> result) {
         ThreadManager.runOnMainThread(
             new Runnable() {
                 @Override
                 public void run() {
                     try {
-                        long networkCharLimit = InternalCore.INSTANCE.get_networkLogCharLimit();
+                        double networkCharLimit = InternalCore.INSTANCE.get_networkLogCharLimit();
                         result.success(networkCharLimit);
                     } catch (Exception e) {
                         e.printStackTrace();

lib/src/modules/instabug.dart

@@ -191,7 +191,7 @@ class Instabug {
       invocationEvents.mapToString(),
       debugLogsLevel.toString(),
     );
-    return FeatureFlagsManager().registerW3CFlagsListener();
+    return FeatureFlagsManager().registerFeatureFlagsListener();
   }
 
   /// Sets a [callback] to be called wehenever a screen name is captured to mask

lib/src/utils/feature_flags_manager.dart

@@ -9,6 +9,8 @@ typedef OnW3CFeatureFlagChange = void Function(
   bool isW3cCaughtHeaderEnabled,
 );
 
+typedef OnNetworkBodyMaxSizeChangeCallback = void Function();
+
 class FeatureFlagsManager implements FeatureFlagsFlutterApi {
   // Access the singleton instance
   factory FeatureFlagsManager() {
@@ -23,6 +25,10 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
   // Host API instance
   static InstabugHostApi _host = InstabugHostApi();
 
+  // Callback for network body max size changes
+  static OnNetworkBodyMaxSizeChangeCallback?
+      _onNetworkBodyMaxSizeChangeCallback;
+
   /// @nodoc
   @visibleForTesting
   // Setter for the host API
@@ -38,6 +44,13 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
     // since it breaks the singleton pattern
   }
 
+  /// Sets the callback for network body max size changes
+  // ignore: avoid_setters_without_getters
+  set onNetworkBodyMaxSizeChangeCallback(
+      OnNetworkBodyMaxSizeChangeCallback callback) {
+    _onNetworkBodyMaxSizeChangeCallback = callback;
+  }
+
   // Internal state flags
   bool _isAndroidW3CExternalTraceID = false;
   bool _isAndroidW3CExternalGeneratedHeader = false;
@@ -67,9 +80,10 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
     );
   }
 
-  Future<void> registerW3CFlagsListener() async {
+  Future<void> registerFeatureFlagsListener() async {
     FeatureFlagsFlutterApi.setup(this); // Use 'this' instead of _instance
 
+    // W3C Feature Flags
     final featureFlags = await _host.isW3CFeatureFlagsEnabled();
     _isAndroidW3CCaughtHeader =
         featureFlags['isW3cCaughtHeaderEnabled'] ?? false;
@@ -78,6 +92,10 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
     _isAndroidW3CExternalGeneratedHeader =
         featureFlags['isW3cExternalGeneratedHeaderEnabled'] ?? false;
 
+    // Network Body Max Size
+    final networkBodyMaxSize = await _host.getNetworkBodyMaxSize();
+    _networkBodyMaxSize = networkBodyMaxSize?.toInt() ?? 0;
+
     return _host.registerFeatureFlagChangeListener();
   }
 
@@ -96,5 +114,6 @@ class FeatureFlagsManager implements FeatureFlagsFlutterApi {
   @override
   void onNetworkLogBodyMaxSizeChange(int networkBodyMaxSize) {
     _networkBodyMaxSize = networkBodyMaxSize;
+    _onNetworkBodyMaxSizeChangeCallback?.call();
   }
 }

lib/src/utils/network_manager.dart

@@ -18,6 +18,14 @@ class NetworkManager {
   int _defaultNetworkBodyMaxSize = 10240; // in bytes
   final _host = InstabugHostApi();
 
+  NetworkManager() {
+    // Register for network body max size changes
+    FeatureFlagsManager().onNetworkBodyMaxSizeChangeCallback =
+        () {
+      clearNetworkBodyMaxSizeCache();
+    };
+  }
+
   // ignore: use_setters_to_change_properties
   void setObfuscateLogCallback(ObfuscateLogCallback callback) {
     _obfuscateLogCallback = callback;
@@ -109,20 +117,23 @@ class NetworkManager {
   /// Gets the network body max size from native SDK, with caching
   Future<int?> _getNetworkBodyMaxSize() async {
     if (_cachedNetworkBodyMaxSize != null) {
+      print('[Kamal] _cachedNetworkBodyMaxSize: $_cachedNetworkBodyMaxSize');
       return _cachedNetworkBodyMaxSize;
     }
 
     final ffmNetworkBodyLimit = FeatureFlagsManager().networkBodyMaxSize;
 
     if (ffmNetworkBodyLimit > 0) {
       _cachedNetworkBodyMaxSize = ffmNetworkBodyLimit;
+      print('[Kamal] ffmNetworkBodyLimit: $ffmNetworkBodyLimit');
       return ffmNetworkBodyLimit;
     }
 
     try {
       final limit = await _host.getNetworkBodyMaxSize();
-      _cachedNetworkBodyMaxSize = limit;
-      return limit;
+      _cachedNetworkBodyMaxSize = limit?.toInt();
+      print('[Kamal] limit: $limit');
+      return limit?.toInt();
     } catch (error) {
       InstabugLogger.I.e(
         'Failed to get network body max size from native API: $error'
@@ -131,7 +142,13 @@ class NetworkManager {
         tag: InstabugConstants.networkManagerTag,
       );
       _cachedNetworkBodyMaxSize = _defaultNetworkBodyMaxSize;
+      print('[Kamal] _defaultNetworkBodyMaxSize: $_defaultNetworkBodyMaxSize');
       return _defaultNetworkBodyMaxSize;
     }
   }
+
+  /// Clears the cached network body max size
+  void clearNetworkBodyMaxSizeCache() {
+    _cachedNetworkBodyMaxSize = null;
+  }
 }

pigeons/instabug.api.dart

@@ -80,5 +80,5 @@ abstract class InstabugHostApi {
   void setNetworkLogBodyEnabled(bool isEnabled);
 
   @async
-  int? getNetworkBodyMaxSize();
+  double? getNetworkBodyMaxSize();
 }

test/feature_flags_manager_test.dart

@@ -54,7 +54,7 @@ void main() {
         "isW3cCaughtHeaderEnabled": true,
       }),
     );
-    await FeatureFlagsManager().registerW3CFlagsListener();
+    await FeatureFlagsManager().registerFeatureFlagsListener();
 
     final isW3CExternalTraceID =
         await FeatureFlagsManager().getW3CFeatureFlagsHeader();
@@ -75,7 +75,7 @@ void main() {
       }),
     );
 
-    await FeatureFlagsManager().registerW3CFlagsListener();
+    await FeatureFlagsManager().registerFeatureFlagsListener();
 
     verify(
       mInstabugHost.registerFeatureFlagChangeListener(),