COMP: Prefer brace initialization

Since C++11, the brace form {} is preferred in most cases because it provides
safer, more consistent, and less surprising behavior.

{} (brace initialization) disallows implicit conversions that lose information.

Author: hjmjohnson

Modules/Bridge/NumPy/include/itkPyBuffer.hxx

@@ -112,7 +112,7 @@ PyBuffer<TImage>::_get_image_view_from_contiguous_array(PyObject * arr, PyObject
   using InternalPixelType = typename TImage::InternalPixelType;
   using ImporterType = ImportImageContainer<SizeValueType, InternalPixelType>;
   auto           importer = ImporterType::New();
-  constexpr bool importImageFilterWillOwnTheBuffer = false;
+  constexpr bool importImageFilterWillOwnTheBuffer{ false };
   auto * const   data = static_cast<InternalPixelType *>(buffer);
   importer->SetImportPointer(data, numberOfPixels, importImageFilterWillOwnTheBuffer);
 

Modules/Bridge/VtkGlue/test/itkImageToVTKImageFilterRGBTest.cxx

@@ -34,7 +34,7 @@ itkImageToVTKImageFilterRGBTest(int argc, char * argv[])
   }
   const char * inputFileName = argv[1];
 
-  constexpr unsigned int Dimension = 2;
+  constexpr unsigned int Dimension{ 2 };
   using PixelComponentType = unsigned char;
   using PixelType = itk::RGBPixel<PixelComponentType>;
   using ImageType = itk::Image<PixelType, Dimension>;

Modules/Bridge/VtkGlue/test/itkImageToVTKImageFilterTest.cxx

@@ -25,7 +25,7 @@
 int
 itkImageToVTKImageFilterTest(int, char *[])
 {
-  constexpr int dim = 3;
+  constexpr int dim{ 3 };
   using ImageType = itk::Image<float, dim>;
   using SourceType = itk::RandomImageSource<ImageType>;
   using SpacingType = SourceType::SpacingType;

Modules/Bridge/VtkGlue/test/itkVTKImageToImageFilterTest.cxx

@@ -25,7 +25,7 @@
 int
 itkVTKImageToImageFilterTest(int, char *[])
 {
-  constexpr int dim = 2;
+  constexpr int dim{ 2 };
   using ImageType = itk::Image<double, dim>;
   using VTKNoiseType = vtkSmartPointer<vtkImageNoiseSource>;
   using ConnectorType = itk::VTKImageToImageFilter<ImageType>;

Modules/Bridge/VtkGlue/test/runViewImage.cxx

@@ -54,7 +54,7 @@ runViewImage(int argc, char * argv[])
   }
   const std::string inputImage = argv[1];
 
-  constexpr unsigned int dimension = 3;
+  constexpr unsigned int dimension{ 3 };
   using PixelType = float;
   using ImageType = itk::Image<PixelType, dimension>;
   using ReaderType = itk::ImageFileReader<ImageType>;

Modules/Core/Common/include/itkBresenhamLine.hxx

@@ -32,7 +32,7 @@ BresenhamLine<VDimension>::BuildLine(LType Direction, IdentifierType length) ->
 
   Direction.Normalize();
   // we are going to start at 0
-  constexpr IndexType StartIndex = { { 0 } };
+  constexpr IndexType StartIndex{ 0 };
   IndexType           LastIndex;
   for (unsigned int i = 0; i < VDimension; ++i)
   {

Modules/Core/Common/include/itkDerivativeOperator.h

@@ -39,7 +39,7 @@ namespace itk
          using DerivativeOperatorType = itk::DerivativeOperator<float, 2>;
          DerivativeOperatorType derivativeOperator;
          derivativeOperator.SetDirection(0); // X dimension
-         constexpr auto radius = itk::Size<2>::Filled(1); // A radius of 1 in both dimensions is a 3x3 operator
+         constexpr  auto radius{ itk::Size<2>::Filled(1) }; // A radius of 1 in both dimensions is a 3x3 operator
          derivativeOperator.CreateToRadius(radius);
    \endcode
  * and creates a kernel that looks like:

Modules/Core/Common/include/itkGaussianDerivativeOperator.h

@@ -171,7 +171,7 @@ class ITK_TEMPLATE_EXPORT GaussianDerivativeOperator : public NeighborhoodOperat
   void
   SetMaximumError(const double maxerror)
   {
-    constexpr double Min = 0.00001;
+    constexpr double Min{ 0.00001 };
     const double     Max = 1.0 - Min;
 
     m_MaximumError = std::clamp(maxerror, Min, Max);

Modules/Core/Common/include/itkGaussianDerivativeOperator.hxx

@@ -222,7 +222,7 @@ template <typename TPixel, unsigned int VDimension, typename TAllocator>
 double
 GaussianDerivativeOperator<TPixel, VDimension, TAllocator>::ModifiedBesselI(int n, double y)
 {
-  constexpr double DIGITS = 10.0;
+  constexpr double DIGITS{ 10.0 };
 
   if (n < 2)
   {

Modules/Core/Common/include/itkGaussianOperator.hxx

@@ -137,7 +137,7 @@ template <typename TPixel, unsigned int VDimension, typename TAllocator>
 double
 GaussianOperator<TPixel, VDimension, TAllocator>::ModifiedBesselI(int n, double y)
 {
-  constexpr double ACCURACY = 40.0;
+  constexpr double ACCURACY{ 40.0 };
 
   if (n < 2)
   {