Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella] Improve test coverages #156

Open
kerthcet opened this issue Sep 12, 2024 · 4 comments
Open

[Umbrella] Improve test coverages #156

kerthcet opened this issue Sep 12, 2024 · 4 comments
Labels
cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Good for newcomers needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Comments

@kerthcet
Copy link
Member

This is the currently unit test coverage:

∅  api/core/v1alpha1 (64ms)
∅  pkg (5ms)
∅  api/inference/v1alpha1 (43ms)
∅  pkg/controller (33ms)
∅  pkg/cert (78ms)
∅  pkg/controller/inference (28ms)
∅  pkg/webhook (23ms)
✓  pkg/controller_helper/model_source (1.014s) (coverage: 4.8% of statements)
✓  pkg/controller_helper (2.011s) (coverage: 3.6% of statements)
✓  pkg/util (3.184s) (coverage: 5.8% of statements)

We need to improve this.
@kerthcet
Copy link
Member Author

/kind cleanup

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a label and requires one. labels Sep 12, 2024
@kerthcet
Copy link
Member Author

/good-first-issue

@InftyAI-Agent InftyAI-Agent added the good first issue Good for newcomers label Sep 12, 2024
@kerthcet kerthcet pinned this issue Sep 12, 2024
@googs1025
Copy link
Contributor

I am trying to get involved and familiar with this project, I am willing to help
/assign

@kerthcet
Copy link
Member Author

Thanks @googs1025

@googs1025 googs1025 mentioned this issue Sep 14, 2024
Merged
@kerthcet kerthcet unpinned this issue Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Good for newcomers needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kerthcet @googs1025 @InftyAI-Agent