Commit 2d2fac3
committed
Fix corrupt trend pptx when score trends upward
The Score Trajectory slide drew connecting lines between data points
with width = p2.x - p1.x and height = p2.y - p1.y. When the org's score
improves between periods, y decreases (smaller y means higher up the
chart), so the height was negative.
Some Office versions silently corrupt the pptx when a shape has
negative dimensions: writeFile reports success and the file looks
intact on disk, but the slide rels reference an unwritten slide and
the file fails to open ("file or directory is corrupted and
unreadable"). Reproduced with two- and three-period histories that
trend upward.
Always pass positive width/height and use flipV when the trajectory
goes up. Result: 3-month upward histories now render correctly across
all three trend slides.
Also refresh the committed Slide2 screenshot to match the deck the
generator now produces (rich tier narrative + 3 cards + focus and
strengths).1 parent c4307c9 commit 2d2fac3
2 files changed
Lines changed: 12 additions & 5 deletions
Loading
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
277 | 282 | | |
278 | 283 | | |
279 | 284 | | |
280 | | - | |
| 285 | + | |
| 286 | + | |
281 | 287 | | |
282 | 288 | | |
283 | | - | |
284 | | - | |
285 | | - | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
286 | 293 | | |
287 | 294 | | |
288 | 295 | | |
| |||
0 commit comments