Indy-10.7 branch issue with indylaz.lpk

[MWASoftware]

The indylaz.lpk package should include the
-Ur
option. Otherwise, building the package can sometimes fail with a problem due to file checksum errors.

[rlebeau]

Can you be more specific? What is the -Ur option, where should it go, and what does it address?

[JPeterMugaas]

I encountered something similar in TaurusTLS. A better solution may be disabling inline. See: https://forum.lazarus.freepascal.org/index.php/topic,71957.0.html

[MWASoftware]

Just add -Ur to the indylaz package options (see image above). The unit references for Indy are almost circular and this options seems necessary to avoid compiler issues

[rlebeau]

Just add -Ur to the indylaz package options (see image above).

I don't have or use Lazarus, so that screen is useless to me. I assume you are referring to the <CustomOptions> element inside of indylaz.lpk:

<?xml version="1.0" encoding="UTF-8"?>
<CONFIG>
  <Package Version="5">
    ...
    <CompilerOptions>
      ...
      <Other>
        <CustomOptions Value="$(IDEBuildOptions)
-dDEBUG -Ur"/> // <-- HERE
      </Other>
    </CompilerOptions>
    ...
  </Package>
</CONFIG>

The unit references for Indy are almost circular

They shouldn't be. Which references do you think are problematic?

[MWASoftware]

On my system, the XML looks like:

      </SearchPaths>
      <Other>
        <CustomOptions Value="-Ur"/>
      </Other>
    </CompilerOptions>

but the actual value can include other settings, such as defining a DEBUG symbol.

The problem seems to be a bug/feature in fpc. Where you have a lot of units with (legal) references to other units from their "implementation" units clause, the compiler can get confused and try to recompile a unit more than once and gets the checksum error. "-Ur" is the workaround that I use to avoid this problem and have never had any problems with it.

I reported this after compiling the 10.7 indylaz in order to test out the issue that @RoLex had reported and got this compile error with IdStreamVCL. Adding "-Ur" corrected the problem. Note that a cleanup and rebuild can also work, but it is annoying to have to do it all the time.

This is not a new issue, I have come across it with previous versions of Indy and locally worked around it each time. This time, I thought that I would report it.

While we are on the subject, I would like to change the lazarus package structure to the same as used for Delphi. indylaz is both a design and runtime package and only really works for GUI programs. Console mode programs that use indylaz end up with unnecessary LCL units. It would be better to have separate runtime packages for Protocols, Core and System, and reduce indylaz to a design time package with references to the other packages.

This is all working in my proposedupdate fork. I can prepare a pull request for the Indy-10.7 branch if you are agreeable to this.

[rlebeau]

The problem seems to be a bug/feature in fpc. Where you have a lot of units with (legal) references to other units from their "implementation" units clause, the compiler can get confused and try to recompile a unit more than once and gets the checksum error. "-Ur" is the workaround that I use to avoid this problem and have never had any problems with it.

Do you have the same problem if you install Indy using OPM instead of building indylaz directly?

While we are on the subject, I would like to change the lazarus package structure to the same as used for Delphi. indylaz is both a design and runtime package and only really works for GUI programs. Console mode programs that use indylaz end up with unnecessary LCL units. It would be better to have separate runtime packages for Protocols, Core and System, and reduce indylaz to a design time package with references to the other packages.

I'm not against that, but I don't know how that will play out with OPM. I've never been involved with the Lazarus side of Indy's setup.

This is all working in my proposedupdate fork. I can prepare a pull request for the Indy-10.7 branch if you are agreeable to this.

Your ProposedUpdate fork includes OpenSSL work, but OpenSSL has already been split out of the main Indy library for 10.7 in favor of the new IndyTLSOpenSSL package, so you should update your fork accordingly.

Actually, I'm tempted/leaning towards having Indy use TaurusTLS as it's official OpenSSL implementation going forward after 10.7's release, where IndyTLSOpenSSL 1.0 would be for backwards compatibility only. But that is not set in stone yet. I'm not against letting IndyTLSOpenSSL 2.0 support the latest OpenSSL, too. But that is just more work to duplicate efforts. Unless TaurusTLS or your ProposedUpdate gets merged into IndyTLSOpenSSL later.

[MWASoftware]

Your ProposedUpdate fork includes OpenSSL work, but OpenSSL has already been split out of the main Indy library for 10.7 in favor of the new IndyTLSOpenSSL package, so you should update your fork accordingly.

Yes, that's why I put forward a pull request for my IndyTLSOpenSSL fork, which updates your original with the SSL support from my proposed update and which @RoLex has been evaluating and helping to make good for FPC and Delphi on both Windows and Lazarus. I believe that you have also contributed to that discussion.

I am keeping both repos up-to-date so that users can continue to use either.

[MWASoftware]

I'm not against that, but I don't know how that will play out with OPM. I've never been involved with the Lazarus side of Indy's setup.

OPM seems to be able to cope with package dependencies and to automatically resolve them. It certainly appears to cope with the dependency between my ibx4lazarus and fbintf packages.

OPM just installs the packages as they are defined so I would expect there to be no differences when it comes to compilation issues.

[MWASoftware]

The indylaz.lpk package should include the -Ur option. Otherwise, building the package can sometimes fail with a problem due to file checksum errors.

Postscript to the above: I have just set up a KVM VM with a clean install of Windows-11 and the most recent version of lazarus and FPC and intended for testing with Indy-10.7. The initial installation of indylaz.lpk into the lazarus-IDE failed with a "Cannot compile error" due to a file checksum failure. Adding the -Ur custom option fixed the problem.